Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752256AbbEGMJc (ORCPT ); Thu, 7 May 2015 08:09:32 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:25860 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751991AbbEGMJ2 (ORCPT ); Thu, 7 May 2015 08:09:28 -0400 Date: Thu, 7 May 2015 15:09:08 +0300 From: Dan Carpenter To: "Dilger, Andreas" Cc: Mike Shuey , "Drokin, Oleg" , "devel@driverdev.osuosl.org" , "gregkh@linuxfoundation.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "HPDD-discuss@lists.01.org" Subject: Re: [HPDD-discuss] [PATCH] staging: lustre: code cleanup - variable declaration spacing Message-ID: <20150507120908.GG14154@mwanda> References: <1430913775-28350-1-git-send-email-shuey@purdue.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1046 Lines: 25 On Thu, May 07, 2015 at 03:36:05AM +0000, Dilger, Andreas wrote: > On 2015/05/06, 6:02 AM, "Mike Shuey" wrote: > > >Clean up spacing in some variable declarations, to be more consistent. > > > >It's small, but I need to start somewhere. Please let me know if I'm not > >adhering to proper procedure for trivial cleanups. > > It's actually Lustre coding style to align the variable declarations. > Is this something that causes checkpatch.pl to complain? If not, I'd > prefer not to change all of these declarations, since it causes a lot > of code churn for very little benefit. In theory it's nice, but in reality aligning variables doesn't work in .c files. If you look at the patch, almost every declaration block uses higgledy piggledy alignment. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/