Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752241AbbEGNBh (ORCPT ); Thu, 7 May 2015 09:01:37 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:36002 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751758AbbEGNBe (ORCPT ); Thu, 7 May 2015 09:01:34 -0400 Message-ID: <554B622A.7080205@cogentembedded.com> Date: Thu, 07 May 2015 16:01:30 +0300 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Ramneek Mehresh , linux-kernel@vger.kernel.org CC: balbi@ti.com, linux-usb@vger.kernel.org, stern@rowland.harvard.edu, gregkh@linuxfoundation.org Subject: Re: [PATCH 09/10] usb:fsl:otg: Resolve OTG crash issue with another host References: <1431002836-9711-1-git-send-email-ramneek.mehresh@freescale.com> <1431002836-9711-9-git-send-email-ramneek.mehresh@freescale.com> In-Reply-To: <1431002836-9711-9-git-send-email-ramneek.mehresh@freescale.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1264 Lines: 37 Hello. On 5/7/2015 3:47 PM, Ramneek Mehresh wrote: > Resolves kernel crash issue when a USB flash drive is inserted > into USB1 port with USB2 port configured as otg. Removing > "else" block so that the controller coming up in "non-otg" mode > doesn't return -ENODEV. Returning "ENODEV" results in platform > framework unbinding platform-drv from controller resulting in > kernel crash later in hub driver > Signed-off-by: Ramneek Mehresh > --- > drivers/usb/host/ehci-fsl.c | 3 --- > 1 file changed, 3 deletions(-) > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c > index 4bd4b0c..8d55f2b 100644 > --- a/drivers/usb/host/ehci-fsl.c > +++ b/drivers/usb/host/ehci-fsl.c > @@ -180,9 +180,6 @@ static int usb_hcd_fsl_probe(const struct hc_driver *driver, > } > > ehci_fsl->have_hcd = 1; > - } else { > - dev_err(&pdev->dev, "wrong operating mode\n"); > - return -ENODEV; Isn't it easier to just not add this code in the patch #7? WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/