Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751081AbbEGNeG (ORCPT ); Thu, 7 May 2015 09:34:06 -0400 Received: from mail.emea.novell.com ([130.57.118.101]:49546 "EHLO mail.emea.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750843AbbEGNeE (ORCPT ); Thu, 7 May 2015 09:34:04 -0400 Date: Thu, 7 May 2015 15:33:53 +0200 (CEST) From: Jiri Kosina X-X-Sender: jikos@twin.jikos.cz To: Oleg Nesterov cc: NeilBrown , Ingo Molnar , Linus Torvalds , Evgeniy Polyakov , Stephen Smalley , Alex Williamson , linux-kernel , kvm Subject: Re: [PATCH] signals: Generate warning when flush_signals() is called from non-kthread context In-Reply-To: <20150504173515.GA12200@redhat.com> Message-ID: References: <1430502057.4472.255.camel@redhat.com> <20150501193813.GA2812@gmail.com> <20150502183001.07eae212@notabene.brown> <20150504173515.GA12200@redhat.com> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 25 On Mon, 4 May 2015, Oleg Nesterov wrote: > > All the calls in md.c are in a kernel thread so safe, but I'd rather have an > > explicit "uninterruptible, but no load-average" wait.... > > Could you please explain why md_thread() does allow_signal(SIGKILL) ? > > I am just curious. It looks as if we want to allow user-space to "call" > thread->run(), and this looks strange. One would think that this is because md wants to be notified when system is going to be halted/rebooted, and userspace init (whatever that is) decides to do 'kill -9 -1' to perform the final shutdown of md (the question is why it really should be needed, becasue all filesystems should be R/O by that time anyway). -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/