Date: Thu, 7 May 2015 15:58:22 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: "mingo@kernel.org" <mingo@kernel.org>,
        "acme@infradead.org" <acme@infradead.org>,
        "eranian@google.com" <eranian@google.com>,
        "andi@firstfloor.org" <andi@firstfloor.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES
Message-ID: <20150507135822.GU21418@twins.programming.kicks-ass.net>
References: <1430940834-8964-1-git-send-email-kan.liang@intel.com>
 <1430940834-8964-8-git-send-email-kan.liang@intel.com>
 <20150507113524.GG23123@twins.programming.kicks-ass.net>
 <37D7C6CF3E00A74B8858931C1DB2F07701818E8A@SHSMSX103.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F07701818E8A@SHSMSX103.ccr.corp.intel.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 798
Lines: 20

On Thu, May 07, 2015 at 01:56:09PM +0000, Liang, Kan wrote:
> 
> > 
> > 
> > So I changed it slightly to the below; changes are:
> > 
> >  - record 'lost' events to all set bits; after all we really do not
> >    know which event this sample belonged to, only logging to the first
> >    set bit seems 'wrong'.
> 
> If so, the same dropped sample will be count multiple times. It's hard to know
> the exact number of dropped samples.

OTOH if the events are from different consumers, they might think there
are no samples lost, while in fact there are.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/