Date: Thu, 7 May 2015 11:15:20 -0300
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Kan Liang <kan.liang@intel.com>, mingo@kernel.org, eranian@google.com,
        andi@firstfloor.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V8 7/8] perf, x86: introduce PERF_RECORD_LOST_SAMPLES
Message-ID: <20150507141520.GC7862@kernel.org>
References: <1430940834-8964-1-git-send-email-kan.liang@intel.com>
 <1430940834-8964-8-git-send-email-kan.liang@intel.com>
 <20150507113524.GG23123@twins.programming.kicks-ass.net>
 <20150507115446.GD16478@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150507115446.GD16478@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 807
Lines: 21

Em Thu, May 07, 2015 at 01:54:46PM +0200, Peter Zijlstra escreveu:
> On Thu, May 07, 2015 at 01:35:24PM +0200, Peter Zijlstra wrote:
> > 
> >  - dropped the @id field from the record, it is already included in the
> >    @sample_id values.
> 
> Hmm, this would force people to use sample_id; which in general is a
> good idea, but should we really force that on people?

Well, if there are more than one sample, we need it, right? If there is
just one, we don't need it, what is different? Am I needing (even more)
coffee?

/me goes read some code...

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/