Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751704AbbEGOqK (ORCPT ); Thu, 7 May 2015 10:46:10 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:42297 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750780AbbEGOqI (ORCPT ); Thu, 7 May 2015 10:46:08 -0400 Date: Thu, 7 May 2015 10:46:07 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Ramneek Mehresh cc: linux-kernel@vger.kernel.org, , , Subject: Re: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for EHCI drv In-Reply-To: <1431002836-9711-2-git-send-email-ramneek.mehresh@freescale.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 987 Lines: 27 On Thu, 7 May 2015, Ramneek Mehresh wrote: > Make use of ehci_driver_overrides structure for ehci-fsl > driver > > Signed-off-by: Ramneek Mehresh You need to change a lot more than this. See commit a76dd463c58e (USB: EHCI: make ehci-orion a separate driver) as an example of what is needed. In the end, ehci-fsl.ko should be a new driver module, not compiled into ehci-hcd.ko. > + ehci_init_driver(driver, &ehci_fsl_overrides); > + driver->product_desc = "Freescale On-Chip EHCI Host Controller"; > + driver->start = ehci_run; > + driver->start_port_reset = ehci_start_port_reset; Why do you want to override driver->start? The default value for this field is already set to ehci_run. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/