Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751918AbbEGQU7 (ORCPT ); Thu, 7 May 2015 12:20:59 -0400 Received: from mail-bl2on0146.outbound.protection.outlook.com ([65.55.169.146]:23040 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751432AbbEGQU5 (ORCPT ); Thu, 7 May 2015 12:20:57 -0400 X-Greylist: delayed 4709 seconds by postgrey-1.27 at vger.kernel.org; Thu, 07 May 2015 12:20:57 EDT Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none; Message-ID: <554B7AC5.5040401@freescale.com> Date: Thu, 7 May 2015 07:46:29 -0700 From: York Sun User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Lee Jones CC: , , , Subject: Re: Why isn't IRQ shared for i2c-ocore References: <55304D8E.8070204@freescale.com> <55312AF7.7070504@freescale.com> <20150420064231.GE3447@x1> <55352839.70905@freescale.com> <20150420181651.GF3447@x1> <5535460B.2060309@freescale.com> <20150421073534.GK3447@x1> <554A8A8B.1020703@freescale.com> <20150507070149.GB3400@x1> In-Reply-To: <20150507070149.GB3400@x1> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.88.168.49] X-ClientProxiedBy: BY2PR06CA023.namprd06.prod.outlook.com (10.141.250.141) To BY2PR03MB160.namprd03.prod.outlook.com (10.242.36.22) X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB160;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB377; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BY2PR03MB160;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB160; X-Forefront-PRVS: 056929CBB8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(6009001)(377454003)(51704005)(24454002)(479174004)(110136002)(92566002)(86362001)(77156002)(93886004)(23676002)(50986999)(2950100001)(33656002)(36756003)(76176999)(5001960100002)(54356999)(87266999)(189998001)(62966003)(46102003)(50466002)(83506001)(4001350100001)(40100003)(59896002)(42186005)(122386002)(65806001)(66066001)(47776003)(87976001)(77096005);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR03MB160;H:[10.214.82.104];FPR:;SPF:None;MLV:sfv;LANG:en; X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2015 14:46:36.8246 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB160 X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1157 Lines: 31 On 05/07/2015 12:01 AM, Lee Jones wrote: >> I have a follow up question regarding interrupt. I see many I2C bus drivers >> request interrupt with flag = 0. Why not using IRQF_SHARED? > > Probably because that particular IRQ is only used by the I2C > Controller. I'm not exactly sure that you're getting at? Why do you > think it should be shared? You should only flag it as shared if it > is. I am working on a driver for multifunction card with open core I2C controller. The interrupt is shared between I2C and other controller. > >> I understand the performance concern. If there is any other reason, I want to >> know about it before I go too far on my driver. > > This sort of stuff is trivial to fix and shouldn't stand in the way > of you writing and submitting v1 of your driver. > It is trivial to fix. I just want to know if there is any reason the interrupt wasn't shared. Seems not. York -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/