Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751398AbbEGP0m (ORCPT ); Thu, 7 May 2015 11:26:42 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:30054 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750784AbbEGP0k (ORCPT ); Thu, 7 May 2015 11:26:40 -0400 Message-ID: <554B8393.1050103@oracle.com> Date: Thu, 07 May 2015 11:24:03 -0400 From: Boris Ostrovsky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Michal Suchanek , Konrad Rzeszutek Wilk , David Vrabel , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Stefano Stabellini , xen-devel@lists.xenproject.org, Linux Kernel Mailing List Subject: Re: problem building on ARM with XEN enabled References: In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1097 Lines: 36 On 05/07/2015 11:10 AM, Michal Suchanek wrote: > Hello, > > it appears the Linus master tree fails to build on ARM with XEN enabled. > > Since commit 2b953a5e9 xen: Suspend ticks on all CPUs during suspend > > provides the suspend function only for x86 this is not surprising. > > I currently don't use XEN yet but building with XEN enabled was not a > problem in the past so this looks like a regression to me. (+Stefano) Does this fix it: diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c index 224081c..7d0f070 100644 --- a/arch/arm/xen/enlighten.c +++ b/arch/arm/xen/enlighten.c @@ -272,6 +272,7 @@ void xen_arch_pre_suspend(void) { } void xen_arch_post_suspend(int suspend_cancelled) { } void xen_timer_resume(void) { } void xen_arch_resume(void) { } +void xen_arch_suspend(void) { } /* In the hypervisor.S file. */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/