Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751810AbbEGPct (ORCPT ); Thu, 7 May 2015 11:32:49 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:60289 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750784AbbEGPcs (ORCPT ); Thu, 7 May 2015 11:32:48 -0400 X-IronPort-AV: E=Sophos;i="5.13,384,1427752800"; d="scan'208";a="139451182" Date: Thu, 7 May 2015 17:32:31 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Dan Carpenter cc: "Dilger, Andreas" , Mike Shuey , "Drokin, Oleg" , "devel@driverdev.osuosl.org" , "gregkh@linuxfoundation.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "HPDD-discuss@lists.01.org" Subject: Re: [HPDD-discuss] [PATCH] staging: lustre: code cleanup - variable declaration spacing In-Reply-To: <20150507120908.GG14154@mwanda> Message-ID: References: <1430913775-28350-1-git-send-email-shuey@purdue.edu> <20150507120908.GG14154@mwanda> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1155 Lines: 27 On Thu, 7 May 2015, Dan Carpenter wrote: > On Thu, May 07, 2015 at 03:36:05AM +0000, Dilger, Andreas wrote: > > On 2015/05/06, 6:02 AM, "Mike Shuey" wrote: > > > > >Clean up spacing in some variable declarations, to be more consistent. > > > > > >It's small, but I need to start somewhere. Please let me know if I'm not > > >adhering to proper procedure for trivial cleanups. > > > > It's actually Lustre coding style to align the variable declarations. > > Is this something that causes checkpatch.pl to complain? If not, I'd > > prefer not to change all of these declarations, since it causes a lot > > of code churn for very little benefit. > > In theory it's nice, but in reality aligning variables doesn't work in > .c files. If you look at the patch, almost every declaration block uses > higgledy piggledy alignment. Probably the use of tabs and spaces is not consistent. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/