Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751811AbbEGQkr (ORCPT ); Thu, 7 May 2015 12:40:47 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:49333 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699AbbEGQkn (ORCPT ); Thu, 7 May 2015 12:40:43 -0400 X-IronPort-AV: E=Sophos;i="5.13,384,1427760000"; d="scan'208";a="262768957" Date: Thu, 7 May 2015 17:37:57 +0100 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Boris Ostrovsky CC: Michal Suchanek , Konrad Rzeszutek Wilk , David Vrabel , "Thomas Gleixner" , Ingo Molnar , "H. Peter Anvin" , Stefano Stabellini , , "Linux Kernel Mailing List" Subject: Re: problem building on ARM with XEN enabled In-Reply-To: <554B8393.1050103@oracle.com> Message-ID: References: <554B8393.1050103@oracle.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1254 Lines: 40 On Thu, 7 May 2015, Boris Ostrovsky wrote: > On 05/07/2015 11:10 AM, Michal Suchanek wrote: > > Hello, > > > > it appears the Linus master tree fails to build on ARM with XEN enabled. > > > > Since commit 2b953a5e9 xen: Suspend ticks on all CPUs during suspend > > > > provides the suspend function only for x86 this is not surprising. > > > > I currently don't use XEN yet but building with XEN enabled was not a > > problem in the past so this looks like a regression to me. > > > > (+Stefano) > > Does this fix it: Yes, it does. Please go ahead and add it to xentip. > diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c > index 224081c..7d0f070 100644 > --- a/arch/arm/xen/enlighten.c > +++ b/arch/arm/xen/enlighten.c > @@ -272,6 +272,7 @@ void xen_arch_pre_suspend(void) { } > void xen_arch_post_suspend(int suspend_cancelled) { } > void xen_timer_resume(void) { } > void xen_arch_resume(void) { } > +void xen_arch_suspend(void) { } > > > /* In the hypervisor.S file. */ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/