Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751597AbbEGRJd (ORCPT ); Thu, 7 May 2015 13:09:33 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:51855 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750784AbbEGRJ3 (ORCPT ); Thu, 7 May 2015 13:09:29 -0400 Date: Thu, 7 May 2015 18:09:25 +0100 (BST) From: "Maciej W. Rozycki" To: Peter Hurley cc: Robert Schwebel , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: earlycon: no match? In-Reply-To: <5547E447.9020604@hurleysoftware.com> Message-ID: References: <20150503211054.GR15254@pengutronix.de> <55477BC1.6000805@hurleysoftware.com> <20150504194229.GR15254@pengutronix.de> <5547D4DB.8060300@hurleysoftware.com> <20150504205241.GT15254@pengutronix.de> <5547E447.9020604@hurleysoftware.com> User-Agent: Alpine 2.11 (LFD 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1693 Lines: 41 On Mon, 4 May 2015, Peter Hurley wrote: > >> Since 2007, 'console=' is a early param synonym for 'earlycon='; IOW, > >> the message is new but not the behavior. > > > > "console=" had nothing to do with early param before. > > *Yes, it has* since the commit I referenced in the previous email and > the email before that when I noted that 'console=' and 'earlycon=' are > synonyms if CONFIG_SERIAL_EARLYCON=y, and it has been that way since > 2007. > > The only thing that has changed is that I added a diagnostic; _to repeat_, > the earlycon matching code has always run in this case, only the > diagnostic is new. What's the point of having two parameters as synonyms whose syntax is not compatible to each other in the general case? I'd expect the following cases to be handled: 1. Regular console only (no early console requested) => `console=foo...'. 2. Both early and regular console => `earlycon=blah... console=foo...'. 3. Early console handing over to regular console => `earlycon=blah...'. Why do you want to support `console=blah...' too (a question to be asked back in 2007, but better late than never)? If you do need to support such aliasing, then I suggest that you complain about no early console match only if `earlycon=blah...' has been truly used and avoid the warning where `console=blah...' has been used instead (a warning about the latter can be issued where no regular console match happened). Maciej -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/