Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752330AbbEGRls (ORCPT ); Thu, 7 May 2015 13:41:48 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:34086 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752306AbbEGRlp (ORCPT ); Thu, 7 May 2015 13:41:45 -0400 MIME-Version: 1.0 In-Reply-To: <20150506163016.a2d79f89abc7543cb80307ac@linux-foundation.org> References: <20150506163016.a2d79f89abc7543cb80307ac@linux-foundation.org> Date: Thu, 7 May 2015 10:41:43 -0700 Message-ID: Subject: Re: [PATCH 2/3] mm/memblock: Allocate boot time data structures from mirrored memory From: Tony Luck To: Andrew Morton Cc: Linux Kernel Mailing List , "linux-mm@kvack.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1000 Lines: 24 On Wed, May 6, 2015 at 4:30 PM, Andrew Morton wrote: > Gramatically, a function called "memblock_has_mirror()" should return a > bool. This guy is misnamed. "memblock_mirror_flag()"? My misnaming is worse than that ... the intent here is to check whether there is any mirrored memory in the system ... i.e. should we go looking around among memblocks for mirrored memory - or is that a futile quest. Most systems won't have any mirror memory - so we won't want to spam the console logs with a ton of messages about not being able to allocate mirrored memory. I'll rename it to "system_has_mirror_memory()". I'll fix all the other things too and re-spin. Keeping to 80 columns might be challenging in some places. -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/