Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Fri, 17 Jan 2003 12:21:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Fri, 17 Jan 2003 12:21:06 -0500 Received: from noodles.codemonkey.org.uk ([213.152.47.19]:59812 "EHLO noodles.internal") by vger.kernel.org with ESMTP id ; Fri, 17 Jan 2003 12:21:05 -0500 Date: Fri, 17 Jan 2003 17:27:19 +0000 From: Dave Jones To: Jeff Garzik Cc: linux-kernel@vger.kernel.org, Florian Lohoff , netdev@oss.sgi.com Subject: Re: eepro100 - 802.1q - mtu size Message-ID: <20030117172719.GA31343@codemonkey.org.uk> Mail-Followup-To: Dave Jones , Jeff Garzik , linux-kernel@vger.kernel.org, Florian Lohoff , netdev@oss.sgi.com References: <20030117145357.GA1139@paradigm.rfc822.org> <20030117160840.GR12676@stingr.net> <20030117162818.GA1074@gtf.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030117162818.GA1074@gtf.org> User-Agent: Mutt/1.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 17, 2003 at 11:28:18AM -0500, Jeff Garzik wrote: > The reason why the patch was not accepted is that it changes one magic > number to another magic number, and without chipset docs, I had no idea > what either magic number really meant. Whilst on the subject of magic numbers in net drivers, did we ever get to the bottom of 2.4's ChangeSet 1.587.9.20 ftp://ftp.kernel.org/pub/linux/kernel/people/davej/patches/2.5/2.5.48/split-dj1/net-cs89x0-media-corrections.diff ? Dave -- | Dave Jones. http://www.codemonkey.org.uk | SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/