Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751668AbbEGVEF (ORCPT ); Thu, 7 May 2015 17:04:05 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46507 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751310AbbEGVEB (ORCPT ); Thu, 7 May 2015 17:04:01 -0400 Message-ID: <554BD33D.7050907@codeaurora.org> Date: Thu, 07 May 2015 14:03:57 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Kevin Hilman CC: =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= , Mike Turquette , Doug Anderson , linux-clk@vger.kernel.org, lkml , "linux-arm-kernel@lists.infradead.org" , Boris Brezillon , Alex Elder , Alexandre Belloni , Stephen Warren , Max Filippov , Sascha Hauer , Zhangfei Gao , Santosh Shilimkar , Chao Xie , Jason Cooper , Stefan Wahren , Andrew Bresticker , Robert Jarzmik , Georgi Djakov , Sylwester Nawrocki , Geert Uytterhoeven , Barry Song , Dinh Nguyen , Viresh Kumar , Gabriel FERNANDEZ , =?UTF-8?B?RW1pbGlvIEzDs3Bleg==?= , Peter De Sc hrijver , Tero Kristo , Ulf Hansson , Pawel Moll , Michal Simek , Olof Johansson , Tyler Baker , Maxime Ripard Subject: Re: [PATCH v3 0/2] clk: improve handling of orphan clocks References: <1429735986-18592-1-git-send-email-heiko@sntech.de> <1981330.kGUrTurMy5@diego> <5543E79F.2080400@codeaurora.org> <22709390.NTAlubMgNB@diego> <55440EDA.4030905@codeaurora.org> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2522 Lines: 60 On 05/07/15 08:17, Kevin Hilman wrote: > On Fri, May 1, 2015 at 4:40 PM, Stephen Boyd wrote: >> On 05/01/15 15:07, Heiko Stübner wrote: >>> Am Freitag, 1. Mai 2015, 13:52:47 schrieb Stephen Boyd: >>> >>>>> Instead I guess we could hook it less deep into clk_get_sys, like in the >>>>> following patch? >>>> It looks like it will work at least, but still I'd prefer to keep the >>>> orphan check contained to clk.c. How about this compile tested only patch? >>> I gave this a spin on my rk3288-firefly board. It still boots, the clock tree >>> looks the same and it also still defers nicely in the scenario I needed it >>> for. The implementation also looks nice - and of course much more compact than >>> my check in two places :-) . I don't know if you want to put this as follow-up >>> on top or fold it into the original orphan-check, so in any case >>> >>> Tested-by: Heiko Stuebner >>> Reviewed-by: Heiko Stuebner >> Thanks. I'm leaning towards tossing your patch 2/2 and replacing it with >> my patch and a note that it's based on an earlier patch from you. > It appears this has landed in linux-next in the form of 882667c1fcf1 > clk: prevent orphan clocks from being used. A bunch of boot failures > for sunxi in today's linux-next[1] were bisected down to that patch. > > I confirmed that reverting that commit on top of next/master gets > sunxi booting again. > > Thanks for the report. I've removed the two clk orphan patches from clk-next. Would it be possible to try with next-20150507 and clk_ignore_unused on the command line? Also we can try to see if critical clocks aren't being forced on by applying this patch and looking for clk_get() failures ------8<------ diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c index 7e1e2bd189b6..d88585b680bb 100644 --- a/drivers/clk/sunxi/clk-sunxi.c +++ b/drivers/clk/sunxi/clk-sunxi.c @@ -1347,6 +1347,9 @@ static void __init sunxi_init_clocks(const char *clocks[], int nclocks) if (!IS_ERR(clk)) clk_prepare_enable(clk); + else + pr_err("Failed to enable critical clock %s\n", + clocks[i]); } } -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/