Date: Thu, 7 May 2015 18:23:02 -0300
From: Ismael Luceno <ismael@iodev.co.uk>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
        Matt Roper <matthew.d.roper@intel.com>,
        intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix screen flickering on X
Message-ID: <20150507182302.4534634d@pirotess>
In-Reply-To: <20150507141827.GW22099@nuc-i3427.alporthouse.com>
References: <1428792034-6131-1-git-send-email-ismael@iodev.co.uk>
	<20150423091532.GA21511@nuc-i3427.alporthouse.com>
	<87zj5g69al.fsf@intel.com>
	<20150507132715.GA22531@intel.com>
	<87r3qs5wtf.fsf@intel.com>
	<20150507141827.GW22099@nuc-i3427.alporthouse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1816
Lines: 48

On Thu, 7 May 2015 15:18:27 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Thu, May 07, 2015 at 04:41:48PM +0300, Jani Nikula wrote:
> > On Thu, 07 May 2015, Matt Roper <matthew.d.roper@intel.com> wrote:
> > > On Thu, May 07, 2015 at 12:12:18PM +0300, Jani Nikula wrote:
> > >> On Thu, 23 Apr 2015, Chris Wilson <chris@chris-wilson.co.uk>
> > >> wrote:
> > >> > [cc'ing the authors]
> > >> 
> > >> This has been posted earlier [1] and it has review to be
> > >> addressed [2].
> > >> 
> > >> BR,
> > >> Jani.
> > >
> > > I agree with Ander's response in [2]...we can't call
> > > intel_update_watermarks() in the commit function because we're
> > > under vblank evasion.  We should already be flagging the
> > > transaction as needing a watermark update in
> > > intel_check_cursor_plane(), and that flag will be acted upon
> > > immediately after the commit functions are done running, once
> > > we've re-enabled interrupts.
> > >
> > > Note that our current codebase looks a bit different since we've
> > > dropped intel_crtc->cursor_{width,height}.  So the relevant check
> > > in intel_check_cursor_plane() now looks like:
> > >
> > >         if (plane->state->crtc_w != state->base.crtc_w)
> > >                 intel_crtc->atomic.update_wm = true;
> > >
> > > Is there a bugzilla open on this issue with more details?
> > 
> > Not that I know of. Ismael?
> > 
> 
> Probably:
> https://bugs.freedesktop.org/show_bug.cgi?id=88944
> https://bugzilla.redhat.com/show_bug.cgi?id=1199890
> are related.
> -Chris
> 

I am experiencing neither of those things.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/