Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751617AbbEGVah (ORCPT ); Thu, 7 May 2015 17:30:37 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45133 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751190AbbEGVag (ORCPT ); Thu, 7 May 2015 17:30:36 -0400 Date: Thu, 7 May 2015 14:30:34 -0700 From: Andrew Morton To: Tony Luck Cc: Linux Kernel Mailing List , "linux-mm@kvack.org" Subject: Re: [PATCH 2/3] mm/memblock: Allocate boot time data structures from mirrored memory Message-Id: <20150507143034.250f8632c8179ba1950d6798@linux-foundation.org> In-Reply-To: References: <20150506163016.a2d79f89abc7543cb80307ac@linux-foundation.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1126 Lines: 26 On Thu, 7 May 2015 14:24:46 -0700 Tony Luck wrote: > On Wed, May 6, 2015 at 4:30 PM, Andrew Morton wrote: > >> + if (!ret && flag) { > >> + pr_warn("Could not allocate %lld bytes of mirrored memory\n", size); > > > > This printk will warn on some configs. Print a phys_addr_t with %pap. > > I think. See huge comment over lib/vsprintf.c:pointer(). > > The comment may be huge - but it seems to lie about phys_addr_t :-( > > I changed to %pap and got: > > mm/memblock.c: In function 'memblock_find_in_range': > mm/memblock.c:276:3: warning: format '%p' expects argument of type > 'void *', but argument 2 has type 'phys_addr_t' [-Wformat=] > pr_warn("Could not allocate %pap bytes of mirrored memory\n", Use "&size" rather than "size". All the %p extensions require a pointer to the thing-to-be-printed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/