Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751504AbbEHAEa (ORCPT ); Thu, 7 May 2015 20:04:30 -0400 Received: from mail-qc0-f178.google.com ([209.85.216.178]:34699 "EHLO mail-qc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbbEHAE1 (ORCPT ); Thu, 7 May 2015 20:04:27 -0400 MIME-Version: 1.0 In-Reply-To: <20150507154212.GA12245@htj.duckdns.org> References: <20150507064557.GA26928@july> <20150507154212.GA12245@htj.duckdns.org> Date: Fri, 8 May 2015 09:04:26 +0900 X-Google-Sender-Auth: b5LdDbFGyW5lXDjKifZQTZLD0nY Message-ID: Subject: Re: [RFC PATCH] PM, freezer: Don't thaw when it's intended frozen processes From: Kyungmin Park To: Tejun Heo Cc: linux-mm , Andrew Morton , "\\Rafael J. Wysocki\\" , David Rientjes , Johannes Weiner , Oleg Nesterov , Cong Wang , LKML , Linux PM list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1875 Lines: 42 On Fri, May 8, 2015 at 12:42 AM, Tejun Heo wrote: > Hello, > > On Thu, May 07, 2015 at 03:45:57PM +0900, Kyungmin Park wrote: >> From: Kyungmin Park >> >> Some platform uses freezer cgroup for speicial purpose to schedule out some applications. but after suspend & resume, these processes are thawed and running. > > They shouldn't be able to leave the freezer tho. Resuming does wake > up all tasks but freezing() test would still evaulate to true for the > ones frozen by cgroup freezer and they will stay inside the freezer. > >> but it's inteneded and don't need to thaw it. >> >> To avoid it, does it possible to modify resume code and don't thaw it when resume? does it resonable? > > I need to think more about it but as an *optimization* we can add > freezing() test before actually waking tasks up during resume, but can > you please clarify what you're seeing? The mobile application has life cycle and one of them is 'suspend' state. it's different from 'pause' or 'background'. if there are some application and enter go 'suspend' state. all behaviors are stopped and can't do anything. right it's suspended. but after system suspend & resume, these application is thawed and running. even though system know it's suspended. We made some test application, print out some message within infinite loop. when it goes 'suspend' state. nothing is print out. but after system suspend & resume, it prints out again. that's not desired behavior. and want to address it. frozen user processes should be remained as frozen while system suspend & resume. Thank you, Kyungmin Park -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/