Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751823AbbEHAFm (ORCPT ); Thu, 7 May 2015 20:05:42 -0400 Received: from mail-vn0-f45.google.com ([209.85.216.45]:36822 "EHLO mail-vn0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751555AbbEHAFk (ORCPT ); Thu, 7 May 2015 20:05:40 -0400 MIME-Version: 1.0 In-Reply-To: <1428079429-4252-6-git-send-email-b.zolnierkie@samsung.com> References: <'@samsung.com> <1428079429-4252-1-git-send-email-b.zolnierkie@samsung.com> <1428079429-4252-6-git-send-email-b.zolnierkie@samsung.com> Date: Fri, 8 May 2015 09:05:39 +0900 X-Google-Sender-Auth: ClEEGqiR-_1AqA6raUfkKSqJ57k Message-ID: Subject: Re: [PATCH 5/6] ARM: Exynos: switch to using generic cpufreq driver for Exynos4210 From: Krzysztof Kozlowski To: Bartlomiej Zolnierkiewicz Cc: Thomas Abraham , Sylwester Nawrocki , Mike Turquette , Kukjin Kim , Kukjin Kim , Viresh Kumar , Tomasz Figa , Lukasz Majewski , Heiko Stuebner , Chanwoo Choi , Kevin Hilman , Javier Martinez Canillas , linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2948 Lines: 85 2015-04-04 1:43 GMT+09:00 Bartlomiej Zolnierkiewicz : > From: Thomas Abraham > > The new CPU clock type allows the use of generic CPUfreq driver. > Switch Exynos4210 to using generic cpufreq driver. > > Changes by Bartlomiej: > - removed non-Exynos4210 support for now > > Cc: Tomasz Figa > Cc: Kukjin Kim > Cc: Javier Martinez Canillas > Signed-off-by: Thomas Abraham > Signed-off-by: Bartlomiej Zolnierkiewicz I know this is an old patch, it looks good. Just a minor nit below. > --- > arch/arm/mach-exynos/exynos.c | 21 ++++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c > index bcde0dd..4e13de5 100644 > --- a/arch/arm/mach-exynos/exynos.c > +++ b/arch/arm/mach-exynos/exynos.c > @@ -197,6 +197,25 @@ static void __init exynos_init_irq(void) > exynos_map_pmu(); > } > > +static const struct of_device_id exynos_cpufreq_matches[] = { > + { .compatible = "samsung,exynos4210", .data = "cpufreq-dt" }, > + { /* sentinel */ } > +}; > + > +static void __init exynos_cpufreq_init(void) > +{ > + struct device_node *root = of_find_node_by_path("/"); > + const struct of_device_id *match; > + > + match = of_match_node(exynos_cpufreq_matches, root); > + if (!match) { > + platform_device_register_simple("exynos-cpufreq", -1, NULL, 0); > + return; > + } > + > + platform_device_register_simple(match->data, -1, NULL, 0); How about something like: const char *cpufreq_dev)name = "exynos-cpufreq"; if (match) cpufreq_dev_name = match->data; platform_device_register_simple(cpufreq_dev_name -1, NULL, 0); Less returns and one call to platform_device_register_simple(). Best regards, Krzysztof > +} > + > static void __init exynos_dt_machine_init(void) > { > /* > @@ -218,7 +237,7 @@ static void __init exynos_dt_machine_init(void) > of_machine_is_compatible("samsung,exynos5250")) > platform_device_register(&exynos_cpuidle); > > - platform_device_register_simple("exynos-cpufreq", -1, NULL, 0); > + exynos_cpufreq_init(); > > of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); > } > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/