Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751870AbbEHA1f (ORCPT ); Thu, 7 May 2015 20:27:35 -0400 Received: from mail.kernel.org ([198.145.29.136]:54670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbbEHA1d convert rfc822-to-8bit (ORCPT ); Thu, 7 May 2015 20:27:33 -0400 MIME-Version: 1.0 In-Reply-To: <554BD33D.7050907@codeaurora.org> References: <1429735986-18592-1-git-send-email-heiko@sntech.de> <1981330.kGUrTurMy5@diego> <5543E79F.2080400@codeaurora.org> <22709390.NTAlubMgNB@diego> <55440EDA.4030905@codeaurora.org> <554BD33D.7050907@codeaurora.org> Date: Thu, 7 May 2015 17:27:22 -0700 Message-ID: Subject: Re: [PATCH v3 0/2] clk: improve handling of orphan clocks From: Kevin Hilman To: Stephen Boyd Cc: Kevin Hilman , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Mike Turquette , Doug Anderson , linux-clk@vger.kernel.org, lkml , "linux-arm-kernel@lists.infradead.org" , Boris Brezillon , Alex Elder , Alexandre Belloni , Stephen Warren , Max Filippov , Sascha Hauer , Zhangfei Gao , Santosh Shilimkar , Chao Xie , Jason Cooper , Stefan Wahren , Andrew Bresticker , Robert Jarzmik , Georgi Djakov , Sylwester Nawrocki , Geert Uytterhoeven , Barry Song , Dinh Nguyen , Viresh Kumar , Gabriel FERNANDEZ , =?UTF-8?Q?Emilio_L=C3=B3pez?= , Peter De Sc hrijver , Tero Kristo , Ulf Hansson , Pawel Moll , Michal Simek , Olof Johansson , Tyler Baker , Maxime Ripard Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2827 Lines: 58 On Thu, May 7, 2015 at 2:03 PM, Stephen Boyd wrote: > On 05/07/15 08:17, Kevin Hilman wrote: >> On Fri, May 1, 2015 at 4:40 PM, Stephen Boyd wrote: >>> On 05/01/15 15:07, Heiko Stübner wrote: >>>> Am Freitag, 1. Mai 2015, 13:52:47 schrieb Stephen Boyd: >>>> >>>>>> Instead I guess we could hook it less deep into clk_get_sys, like in the >>>>>> following patch? >>>>> It looks like it will work at least, but still I'd prefer to keep the >>>>> orphan check contained to clk.c. How about this compile tested only patch? >>>> I gave this a spin on my rk3288-firefly board. It still boots, the clock tree >>>> looks the same and it also still defers nicely in the scenario I needed it >>>> for. The implementation also looks nice - and of course much more compact than >>>> my check in two places :-) . I don't know if you want to put this as follow-up >>>> on top or fold it into the original orphan-check, so in any case >>>> >>>> Tested-by: Heiko Stuebner >>>> Reviewed-by: Heiko Stuebner >>> Thanks. I'm leaning towards tossing your patch 2/2 and replacing it with >>> my patch and a note that it's based on an earlier patch from you. >> It appears this has landed in linux-next in the form of 882667c1fcf1 >> clk: prevent orphan clocks from being used. A bunch of boot failures >> for sunxi in today's linux-next[1] were bisected down to that patch. >> >> I confirmed that reverting that commit on top of next/master gets >> sunxi booting again. >> >> > > Thanks for the report. I've removed the two clk orphan patches from > clk-next. Would it be possible to try with next-20150507 and > clk_ignore_unused on the command line? That doesn't help. I tried on cubieboard2 and bananapi. > Also we can try to see if > critical clocks aren't being forced on by applying this patch and > looking for clk_get() failures >From cubieboard2, there's a few that look rather important: [ 0.000000] Additional per-CPU info printed with stalls. [ 0.000000] Build-time adjustment of leaf fanout to 32. [ 0.000000] RCU restricting CPUs from NR_CPUS=16 to nr_cpu_ids=2. [ 0.000000] RCU: Adjusting geometry for rcu_fanout_leaf=32, nr_cpu_ids=2 [ 0.000000] NR_IRQS:16 nr_irqs:16 16 [ 0.000000] clk: couldn't get parent clock 0 for /clocks/ahb@01c20054 [ 0.000000] Failed to enable critical clock cpu [ 0.000000] Failed to enable critical clock pll5_ddr [ 0.000000] Failed to enable critical clock ahb_sdram [ 0.000000] Architected cp15 timer(s) running at 24.00MHz (virt). Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/