Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752192AbbEHAmX (ORCPT ); Thu, 7 May 2015 20:42:23 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.229]:50699 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751255AbbEHAmW (ORCPT ); Thu, 7 May 2015 20:42:22 -0400 Date: Thu, 7 May 2015 20:42:28 -0400 From: Steven Rostedt To: Drew Richardson Cc: Peter Zijlstra , Mathieu Desnoyers , Ingo Molnar , "linux-kernel@vger.kernel.org" , Thomas Gleixner , John Stultz , Wade Cherry , Pawel Moll Subject: Re: [PATCH] ftrace: Provide trace clock monotonic raw Message-ID: <20150507204228.0cb8b55c@grimm.local.home> In-Reply-To: <20150505145438.GA5145@dreric01-Precision-T1650> References: <1430750469-16428-1-git-send-email-drew.richardson@arm.com> <199091314.42407.1430752205090.JavaMail.zimbra@efficios.com> <20150504200515.GA24626@dreric01-Precision-T1650> <20150504205748.GB21418@twins.programming.kicks-ass.net> <20150505145438.GA5145@dreric01-Precision-T1650> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.130:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1524 Lines: 34 On Tue, 5 May 2015 07:54:46 -0700 Drew Richardson wrote: > CLOCK_MONOTONIC_RAW will advance more constantly than CLOCK_MONOTONIC. > > Imagine someone is trying to optimize a particular program to reduce > instructions executed for a given workload while minimizing the effect > on runtime. Also suppose that ntp is running and potentially making > larger adjustments to CLOCK_MONOTONIC. If ntp is adjusting > CLOCK_MONOTONIC to advance more rapidly, the program will appear to > use fewer instructions per second but run longer than it would if > CLOCK_MONOTONIC_RAW had been used. The total number of instructions > observed would be the same regardless of the clock source used, but > how it's attributed to time would be affected. > > Conversely if ntp is adjusting CLOCK_MONOTONIC to advance more slowly, > the program will appear to use more instructions per second but run > more quickly. Of course there are many sources that can cause jitter > in performance measurements on modern processors, but I'd like to > remove ntp from the list. What's the consensus on this patch? Everyone OK with it? If so, can you please post a new patch with the proper change log. And can everyone else give acks. I can take it in my tree. Thanks, -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/