Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752353AbbEHBcj (ORCPT ); Thu, 7 May 2015 21:32:39 -0400 Received: from mga09.intel.com ([134.134.136.24]:3316 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751304AbbEHBch convert rfc822-to-8bit (ORCPT ); Thu, 7 May 2015 21:32:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,387,1427785200"; d="scan'208";a="725691533" From: "Drokin, Oleg" To: Dan Carpenter CC: "Dilger, Andreas" , Mike Shuey , "devel@driverdev.osuosl.org" , "gregkh@linuxfoundation.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "HPDD-discuss@lists.01.org" Subject: Re: [HPDD-discuss] [PATCH] staging: lustre: code cleanup - variable declaration spacing Thread-Topic: [HPDD-discuss] [PATCH] staging: lustre: code cleanup - variable declaration spacing Thread-Index: AQHQh/TAgVHyFBCELECfnCbvrJMDop1wU1SAgACPWACAAOB6AA== Date: Fri, 8 May 2015 01:32:34 +0000 Message-ID: References: <1430913775-28350-1-git-send-email-shuey@purdue.edu> <20150507120908.GG14154@mwanda> In-Reply-To: <20150507120908.GG14154@mwanda> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.219.19] Content-Type: text/plain; charset="us-ascii" Content-ID: <443826CDFF186445B141E1A1E23A1A43@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1505 Lines: 32 Hello! On May 7, 2015, at 8:09 AM, Dan Carpenter wrote: >>> Clean up spacing in some variable declarations, to be more consistent. >>> >>> It's small, but I need to start somewhere. Please let me know if I'm not >>> adhering to proper procedure for trivial cleanups. >> >> It's actually Lustre coding style to align the variable declarations. >> Is this something that causes checkpatch.pl to complain? If not, I'd >> prefer not to change all of these declarations, since it causes a lot >> of code churn for very little benefit. > In theory it's nice, but in reality aligning variables doesn't work in > .c files. If you look at the patch, almost every declaration block uses > higgledy piggledy alignment. I suspect that that's artefact of the initial code submission where the mostly spaces used for tabs were converted to tabs in some automated manner, which combined with typedefs removals (also done in automated manner) like cfs_spinlock_t to spinlock_t and the like produced the result we can see. Personally I don't care all that much about local variables alignments in the functions, but alignment of struct members does help, I feel like, so I have been trying to fix the alignment there whenever I was touching nearby code. Bye, Oleg-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/