Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752116AbbEHEKU (ORCPT ); Fri, 8 May 2015 00:10:20 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:18778 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066AbbEHEKR (ORCPT ); Fri, 8 May 2015 00:10:17 -0400 Message-ID: <554C3790.4010407@oracle.com> Date: Thu, 07 May 2015 21:12:00 -0700 From: "santosh.shilimkar@oracle.com" Organization: Oracle Corporation User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Suravee Suthikulpanit , rjw@rjwysocki.net, lenb@kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, thomas.lendacky@amd.com, herbert@gondor.apana.org.au, davem@davemloft.net, arnd@arndb.de CC: msalter@redhat.com, hanjun.guo@linaro.org, al.stone@linaro.org, grant.likely@linaro.org, leo.duran@amd.com, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, netdev@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [V3 PATCH 3/5] device property: Introduces device_dma_is_coherent() References: <1431045436-8690-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1431045436-8690-4-git-send-email-Suravee.Suthikulpanit@amd.com> In-Reply-To: <1431045436-8690-4-git-send-email-Suravee.Suthikulpanit@amd.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1603 Lines: 46 On 5/7/15 5:37 PM, Suravee Suthikulpanit wrote: > Currently, device drivers, which support both OF and ACPI, > need to call two separate APIs, of_dma_is_coherent() and > acpi_dma_is_coherent()) to determine device coherency attribute. > > This patch simplifies this process by introducing a new device > property API, device_dma_is_coherent(), which calls the appropriate > interface based on the booting architecture. > > Signed-off-by: Suravee Suthikulpanit > --- > drivers/base/property.c | 12 ++++++++++++ > include/linux/property.h | 2 ++ > 2 files changed, 14 insertions(+) > > diff --git a/drivers/base/property.c b/drivers/base/property.c > index 1d0b116..8123c6e 100644 > --- a/drivers/base/property.c > +++ b/drivers/base/property.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > > /** > @@ -519,3 +520,14 @@ unsigned int device_get_child_node_count(struct device *dev) > return count; > } > EXPORT_SYMBOL_GPL(device_get_child_node_count); > + > +bool device_dma_is_coherent(struct device *dev) > +{ > + if (IS_ENABLED(CONFIG_OF) && dev->of_node) Do you really need that IS_ENABLED(CONFIG_OF) ? In other words, dev->of_node should be null for !CONFIG_OF Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/