Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752312AbbEHEiO (ORCPT ); Fri, 8 May 2015 00:38:14 -0400 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:56795 "EHLO e23smtp03.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752027AbbEHEiN (ORCPT ); Fri, 8 May 2015 00:38:13 -0400 Message-ID: <554C3D7B.1000408@linux.vnet.ibm.com> Date: Fri, 08 May 2015 10:07:15 +0530 From: Shreyas B Prabhu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Steven Rostedt CC: Preeti Murthy , Paul McKenney , LKML , Ingo Molnar , aneesh.kumar@linux.vnet.ibm.com, Preeti U Murthy Subject: Re: [PATCH 3/3] tracing/mm: Don't trace mm_page_pcpu_drain on offline cpus References: <1430236283-29360-1-git-send-email-shreyas@linux.vnet.ibm.com> <1430236283-29360-3-git-send-email-shreyas@linux.vnet.ibm.com> <5540EF78.8000409@linux.vnet.ibm.com> <20150429111812.60b697c6@gandalf.local.home> <5540FFAE.2050502@linux.vnet.ibm.com> <20150429130852.487100d9@gandalf.local.home> In-Reply-To: <20150429130852.487100d9@gandalf.local.home> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15050804-0009-0000-0000-0000015B7ABE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1430 Lines: 42 On Wednesday 29 April 2015 10:38 PM, Steven Rostedt wrote: > On Wed, 29 Apr 2015 21:28:38 +0530 > Shreyas B Prabhu wrote: > >> >> >> On Wednesday 29 April 2015 08:48 PM, Steven Rostedt wrote: >>> On Wed, 29 Apr 2015 20:19:28 +0530 >>> Shreyas B Prabhu wrote: >>> >>>> IIUC there is no existing macro which can both add a condition and >>>> override printk format, hence the fall back to TRACE_EVENT_CONDITION. >>> >>> Hmm, want me to send you a patch that changes that? >>> >> I am not sure if its worth the effort now. It doesn't look like any >> other trace point apart from the above use case will benefit from it. >> Only smbus_write and smbus_reply seem to come close. But even they need >> separate TP_fast_assign. > > It shouldn't be a problem to implement. But I'm currently cleaning up > those files, and any changes will cause nasty conflicts. > > Lets do this. Push the current changes as is, and when I get around to > adding a DEFINE_EVENT_PRINT_CONDITION(), we can modify that code to use > it. > Hi Steve, Do you have any other suggestions for this patchset or will you take them as is? Thanks, Shreyas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/