From: Ramneek Mehresh <ramneek.mehresh@freescale.com>
To: Alan Stern <stern@rowland.harvard.edu>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "balbi@ti.com" <balbi@ti.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: RE: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for
 EHCI drv
Thread-Topic: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for
 EHCI drv
Thread-Index: AQHQiMJfIXxmm4goP0yRszanEkdHF51wl5SAgADuGhA=
Date: Fri, 8 May 2015 05:03:55 +0000
Message-ID: <SN1PR0301MB1583E7B2CFB5044E9850DFD9E0DE0@SN1PR0301MB1583.namprd03.prod.outlook.com>
References: <1431002836-9711-2-git-send-email-ramneek.mehresh@freescale.com>
 <Pine.LNX.4.44L0.1505071037180.2272-100000@iolanthe.rowland.org>
In-Reply-To: <Pine.LNX.4.44L0.1505071037180.2272-100000@iolanthe.rowland.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2015 05:03:55.0864
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB1583
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1694
Lines: 42


> -----Original Message-----
> From: Alan Stern [mailto:stern@rowland.harvard.edu]
> Sent: Thursday, May 07, 2015 8:16 PM
> To: Mehresh Ramneek-B31383
> Cc: linux-kernel@vger.kernel.org; balbi@ti.com; linux-usb@vger.kernel.org;
> gregkh@linuxfoundation.org
> Subject: Re: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for
> EHCI drv
> 
> On Thu, 7 May 2015, Ramneek Mehresh wrote:
> 
> > Make use of ehci_driver_overrides structure for ehci-fsl driver
> >
> > Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> 
> You need to change a lot more than this.  See commit a76dd463c58e (USB:
> EHCI: make ehci-orion a separate driver) as an example of what is needed.  In
> the end, ehci-fsl.ko should be a new driver module, not compiled into ehci-
> hcd.ko.
> 
I can definitely make this change, but this patch set is about OTG functionality
fix for all FSL QorIQ socs. Changes you are asking are for FSL Host driver. For that 
I can float separate patch/patch set. Hence, I would request you to please accept the
Patch series in conext of OTG functionality fix 
> > +	ehci_init_driver(driver, &ehci_fsl_overrides);
> > +	driver->product_desc = "Freescale On-Chip EHCI Host Controller";
> > +	driver->start = ehci_run;
> > +	driver->start_port_reset = ehci_start_port_reset;
> 
> Why do you want to override driver->start?  The default value for this field is
> already set to ehci_run.
> 
Will correct this
> Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/