From: Ramneek Mehresh <ramneek.mehresh@freescale.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC: "balbi@ti.com" <balbi@ti.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: RE: [PATCH 09/10] usb:fsl:otg: Resolve OTG crash issue with another
 host
Thread-Topic: [PATCH 09/10] usb:fsl:otg: Resolve OTG crash issue with another
 host
Thread-Index: AQHQiMJqqRKjgahTu0aJTj46807SzJ1welkAgAETsQA=
Date: Fri, 8 May 2015 05:28:42 +0000
Message-ID: <SN1PR0301MB15830252FB18C65A457FEA1FE0DE0@SN1PR0301MB1583.namprd03.prod.outlook.com>
References: <1431002836-9711-1-git-send-email-ramneek.mehresh@freescale.com>
 <1431002836-9711-9-git-send-email-ramneek.mehresh@freescale.com>
 <554B622A.7080205@cogentembedded.com>
In-Reply-To: <554B622A.7080205@cogentembedded.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2015 05:28:43.0266
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB1583
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1733
Lines: 50


> -----Original Message-----
> From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com]
> Sent: Thursday, May 07, 2015 6:32 PM
> To: Mehresh Ramneek-B31383; linux-kernel@vger.kernel.org
> Cc: balbi@ti.com; linux-usb@vger.kernel.org; stern@rowland.harvard.edu;
> gregkh@linuxfoundation.org
> Subject: Re: [PATCH 09/10] usb:fsl:otg: Resolve OTG crash issue with another
> host
> 
> Hello.
> 
> On 5/7/2015 3:47 PM, Ramneek Mehresh wrote:
> 
> > Resolves kernel crash issue when a USB flash drive is inserted into
> > USB1 port with USB2 port configured as otg. Removing "else" block so
> > that the controller coming up in "non-otg" mode doesn't return
> > -ENODEV. Returning "ENODEV" results in platform framework unbinding
> > platform-drv from controller resulting in kernel crash later in hub
> > driver
> 
> > Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> > ---
> >   drivers/usb/host/ehci-fsl.c | 3 ---
> >   1 file changed, 3 deletions(-)
> 
> > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> > index 4bd4b0c..8d55f2b 100644
> > --- a/drivers/usb/host/ehci-fsl.c
> > +++ b/drivers/usb/host/ehci-fsl.c
> > @@ -180,9 +180,6 @@ static int usb_hcd_fsl_probe(const struct hc_driver
> *driver,
> >   		}
> >
> >   		ehci_fsl->have_hcd = 1;
> > -	} else {
> > -		dev_err(&pdev->dev, "wrong operating mode\n");
> > -		return -ENODEV;
> 
>    Isn't it easier to just not add this code in the patch #7?
> 
Will do, thanks
> WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/