Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752558AbbEHHI4 (ORCPT ); Fri, 8 May 2015 03:08:56 -0400 Received: from mail-vn0-f54.google.com ([209.85.216.54]:40447 "EHLO mail-vn0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752353AbbEHHIx (ORCPT ); Fri, 8 May 2015 03:08:53 -0400 From: Len Brown To: rjw@rjwysocki.net, linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Len Brown Subject: [PATCH 1/1] suspend: delete sys_sync() Date: Fri, 8 May 2015 03:08:43 -0400 Message-Id: X-Mailer: git-send-email 2.4.0.rc1 Reply-To: Len Brown Organization: Intel Open Source Technology Center Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1346 Lines: 41 From: Len Brown Remove sys_sync() from the kernel's suspend flow. sys_sync() is extremely expensive in some configurations, and so the kernel should not force users to pay this cost on every suspend. The user-space utilities s2ram and s2disk choose to invoke sync() today. A user can invoke suspend directly via /sys/power/state to skip that cost. Signed-off-by: Len Brown --- kernel/power/suspend.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c index b7d6b3a..6d237bb 100644 --- a/kernel/power/suspend.c +++ b/kernel/power/suspend.c @@ -473,12 +473,6 @@ static int enter_state(suspend_state_t state) if (state == PM_SUSPEND_FREEZE) freeze_begin(); - trace_suspend_resume(TPS("sync_filesystems"), 0, true); - printk(KERN_INFO "PM: Syncing filesystems ... "); - sys_sync(); - printk("done.\n"); - trace_suspend_resume(TPS("sync_filesystems"), 0, false); - pr_debug("PM: Preparing system for %s sleep\n", pm_states[state]); error = suspend_prepare(state); if (error) -- 2.4.0.rc1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/