Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752741AbbEHIfs (ORCPT ); Fri, 8 May 2015 04:35:48 -0400 Received: from lb3-smtp-cloud3.xs4all.net ([194.109.24.30]:44696 "EHLO lb3-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbbEHIfp (ORCPT ); Fri, 8 May 2015 04:35:45 -0400 Message-ID: <1431074139.11180.7.camel@x220> Subject: Re: [PATCH 10/10] usb:fsl:otg: Make fsl otg driver as tristate From: Paul Bolle To: Ramneek Mehresh Cc: linux-kernel@vger.kernel.org, balbi@ti.com, linux-usb@vger.kernel.org, stern@rowland.harvard.edu, gregkh@linuxfoundation.org Date: Fri, 08 May 2015 10:35:39 +0200 In-Reply-To: <1431002836-9711-10-git-send-email-ramneek.mehresh@freescale.com> References: <1431002836-9711-1-git-send-email-ramneek.mehresh@freescale.com> <1431002836-9711-10-git-send-email-ramneek.mehresh@freescale.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1534 Lines: 43 On Thu, 2015-05-07 at 18:17 +0530, Ramneek Mehresh wrote: > Provide option to load fsl otg driver as loadable > module (Full stop at the end of that sentence, please.) In case anyone is wondering: this is all that's needed to allow the build of a phy-fsl-usb.ko module because the code already contains the required module specific boilerplate. Actually, that boilerplate has always been there since this driver was added in v3.0, as a built-in only driver, through commit 0807c500a1a6 ("USB: add Freescale USB OTG Transceiver driver"). (Of course, this assumes building modular and loading the module actually works, none of which I have tried myself.) > Signed-off-by: Ramneek Mehresh > --- > drivers/usb/phy/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig > index 2175678..4927905 100644 > --- a/drivers/usb/phy/Kconfig > +++ b/drivers/usb/phy/Kconfig > @@ -19,7 +19,7 @@ config AB8500_USB > in host mode, low speed. > > config FSL_USB2_OTG > - bool "Freescale USB OTG Transceiver Driver" > + tristate "Freescale USB OTG Transceiver Driver" > depends on USB_EHCI_FSL && USB_FSL_USB2 && USB_OTG_FSM && PM > select USB_OTG > select USB_PHY Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/