Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752493AbbEHItr (ORCPT ); Fri, 8 May 2015 04:49:47 -0400 Received: from mail-qc0-f173.google.com ([209.85.216.173]:33865 "EHLO mail-qc0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752065AbbEHIto (ORCPT ); Fri, 8 May 2015 04:49:44 -0400 MIME-Version: 1.0 In-Reply-To: <554C766A.8070103@rock-chips.com> References: <1431072968-12696-1-git-send-email-tfiga@chromium.org> <554C766A.8070103@rock-chips.com> From: Tomasz Figa Date: Fri, 8 May 2015 17:49:22 +0900 Message-ID: Subject: Re: [PATCH] drm/rockchip: Add BGR formats to VOP To: Mark yao Cc: dri-devel@lists.freedesktop.org, "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "linux-kernel@vger.kernel.org" , Daniel Kurtz , Heiko Stuebner , David Airlie Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1407 Lines: 41 Hi Mark, Thanks for review. On Fri, May 8, 2015 at 5:40 PM, Mark yao wrote: >> @@ -233,6 +243,7 @@ static const struct vop_win_phy win23_data = { >> .nformats = ARRAY_SIZE(formats_234), >> .enable = VOP_REG(WIN2_CTRL0, 0x1, 0), >> .format = VOP_REG(WIN2_CTRL0, 0x7, 1), >> + .rb_swap = VOP_REG(WIN0_CTRL0, 0x1, 12), > > Should be: > > .rb_swap = VOP_REG(VOP_WIN2_CTRL0, 0x1, 12), > Right, good catch. >> .dsp_info = VOP_REG(WIN2_DSP_INFO0, 0x0fff0fff, 0), >> .dsp_st = VOP_REG(WIN2_DSP_ST0, 0x1fff1fff, 0), >> .yrgb_mst = VOP_REG(WIN2_MST0, 0xffffffff, 0), >> @@ -246,6 +257,7 @@ static const struct vop_win_phy cursor_data = { >> .nformats = ARRAY_SIZE(formats_234), >> .enable = VOP_REG(HWC_CTRL0, 0x1, 0), >> .format = VOP_REG(HWC_CTRL0, 0x7, 1), >> + .rb_swap = VOP_REG(WIN0_CTRL0, 0x1, 12), > > cursor win not support rb_swap, remove it. > Hmm, according to the datasheet of RK3288 I have (0.7, October 2014), there is a field called hwc_rb_swap at bit 12 of HWC_CTRL0 register. Is it an error in the datasheet? Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/