Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753006AbbEHLBV (ORCPT ); Fri, 8 May 2015 07:01:21 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52511 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752981AbbEHLBR (ORCPT ); Fri, 8 May 2015 07:01:17 -0400 Date: Fri, 8 May 2015 13:01:12 +0200 From: Greg Kroah-Hartman To: Lu Baolu Cc: Mathias Nyman , Alan Stern , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/3] usb: xhci: remove stop device and ring doorbell in hub control and bus suspend Message-ID: <20150508110112.GB30150@kroah.com> References: <1431080788-20674-1-git-send-email-baolu.lu@linux.intel.com> <1431080788-20674-4-git-send-email-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431080788-20674-4-git-send-email-baolu.lu@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 699 Lines: 18 On Fri, May 08, 2015 at 06:26:28PM +0800, Lu Baolu wrote: > There is no need to call xhci_stop_device() and xhci_ring_device() in > hub control and bus suspend functions since all device suspend and > resume have been notified through device_suspend/device_resume interfaces. Does this mean that after patch 2, things are broken and require this patch to prevent problems? I don't want to have any patch to make the system unstable. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/