Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753472AbbEHLau (ORCPT ); Fri, 8 May 2015 07:30:50 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:32939 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752972AbbEHLar (ORCPT ); Fri, 8 May 2015 07:30:47 -0400 MIME-Version: 1.0 In-Reply-To: <20150508071340.GA2603@breakpoint.cc> References: <20150507202439.GA4717@breakpoint.cc> <20150508071340.GA2603@breakpoint.cc> Date: Fri, 8 May 2015 08:30:45 -0300 Message-ID: Subject: Re: [PATCH v2] serial: imx: Revert "initialized DMA w/o HW flow enabled" From: Fabio Estevam To: Sebastian Andrzej Siewior Cc: Greg Kroah-Hartman , Sebastian Andrzej Siewior , jiwang , Jiri Slaby , "linux-serial@vger.kernel.org" , linux-kernel , anton_bondarenko@mentor.com, Dirk Behme , Nicolae Rosia , Fabio Estevam Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 28 On Fri, May 8, 2015 at 4:13 AM, Sebastian Andrzej Siewior wrote: > + > + /* > + * Can we enable the DMA support? Be aware that > + * at least IMX6 needs to load external SDMA firmware in > + * order work properly. The in-ROM firmware is not > + * wokring properly. > + */ On my tests: Prior to this patch: with the internal ROM SDMA firmware I got UART issues when communicating through a Bluetooth module. With external SDMA firmware (version 3.1) it worked fine. With your patch applied: Bluetooth worked fine even with no external SDMA firmware, which does not match the comments you added. Can't you just remove these comments? Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/