Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752722AbbEHLnD (ORCPT ); Fri, 8 May 2015 07:43:03 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:42620 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbbEHLm7 (ORCPT ); Fri, 8 May 2015 07:42:59 -0400 Message-ID: <554CA0F4.6010305@ti.com> Date: Fri, 8 May 2015 14:41:40 +0300 From: Tero Kristo User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Stephen Boyd , =?windows-1252?Q?Heiko_St=FCbn?= =?windows-1252?Q?er?= CC: , , , , , Boris Brezillon , Alex Elder , Alexandre Belloni , Stephen Warren , Max Filippov , , Zhangfei Gao , Santosh Shilimkar , Chao Xie , Jason Cooper , Stefan Wahren , Andrew Bresticker , Robert Jarzmik , Georgi Djakov , Sylwester Nawrocki , Geert Uytterhoeven , Barry Song , Dinh Nguyen , Viresh Kumar , Gabriel FERNANDEZ , , Peter De Sc hrijver , Ulf Hansson , Pawel Moll , Michal Simek Subject: Re: [PATCH v3 0/2] clk: improve handling of orphan clocks References: <1429735986-18592-1-git-send-email-heiko@sntech.de> <1981330.kGUrTurMy5@diego> <5543E79F.2080400@codeaurora.org> <22709390.NTAlubMgNB@diego> <55440EDA.4030905@codeaurora.org> <554B20B4.3040003@ti.com> <554BAC8A.1010307@codeaurora.org> In-Reply-To: <554BAC8A.1010307@codeaurora.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3306 Lines: 73 On 05/07/2015 09:18 PM, Stephen Boyd wrote: > On 05/07/15 01:22, Tero Kristo wrote: >> On 05/02/2015 02:40 AM, Stephen Boyd wrote: >>> On 05/01/15 15:07, Heiko St?bner wrote: >>>> Am Freitag, 1. Mai 2015, 13:52:47 schrieb Stephen Boyd: >>>> >>>>>> Instead I guess we could hook it less deep into clk_get_sys, like >>>>>> in the >>>>>> following patch? >>>>> It looks like it will work at least, but still I'd prefer to keep the >>>>> orphan check contained to clk.c. How about this compile tested only >>>>> patch? >>>> I gave this a spin on my rk3288-firefly board. It still boots, the >>>> clock tree >>>> looks the same and it also still defers nicely in the scenario I >>>> needed it >>>> for. The implementation also looks nice - and of course much more >>>> compact than >>>> my check in two places :-) . I don't know if you want to put this as >>>> follow-up >>>> on top or fold it into the original orphan-check, so in any case >>>> >>>> Tested-by: Heiko Stuebner >>>> Reviewed-by: Heiko Stuebner >>> >>> Thanks. I'm leaning towards tossing your patch 2/2 and replacing it with >>> my patch and a note that it's based on an earlier patch from you. >> >> FWIW, just gave a try for these two patches on all TI boards I have >> access to. >> >> Tested-by: Tero Kristo >> >> I didn't try your evolved patch though, as you don't seem to have made >> your mind yet. >> > > Thanks. Can you try the evolved patch? It's in linux-next now as commit > 882667c1fcf1, and it seems to at least break sunxi boot. I'd be > interested if it broke TI boards. Just tried it out, boots fine on all these: : Board : Boot commit log 1: am335x-evm : PASS 4.1.0-rc2-next-20150507 am335x-evm.txt 2: am335x-evmsk : PASS 4.1.0-rc2-next-20150507 am335x-sk.txt 3: am3517-evm : PASS 4.1.0-rc2-next-20150507 am3517-evm.txt 4: am43x-epos-evm : PASS 4.1.0-rc2-next-20150507 am43xx-epos.txt 5: am437x-gp-evm : PASS 4.1.0-rc2-next-20150507 am43xx-gpevm.txt 6: am57xx-evm : PASS 4.1.0-rc2-next-20150507 am57xx-evm.txt 7: omap3-beagle-xm : PASS 4.1.0-rc2-next-20150507 beagleboard.txt 8: omap3-beagle : PASS 4.1.0-rc2-next-20150507 beagleboard-vanilla.txt 9: am335x-boneblack: PASS 4.1.0-rc2-next-20150507 beaglebone-black.txt 10: am335x-bone : PASS 4.1.0-rc2-next-20150507 beaglebone.txt 11: dra7xx-evm : PASS 4.1.0-rc2-next-20150507 dra7xx-evm.txt 12: omap3-n900 : PASS 4.1.0-rc2-next-20150507 n900.txt 13: omap5-uevm : PASS 4.1.0-rc2-next-20150507 omap5-evm.txt 14: omap4-panda-es : PASS 4.1.0-rc2-next-20150507 pandaboard-es.txt 15: omap4-panda : PASS 4.1.0-rc2-next-20150507 pandaboard-vanilla.txt 16: omap2430-sdp : PASS 4.1.0-rc2-next-20150507 sdp2430.txt 17: omap3430-sdp : PASS 4.1.0-rc2-next-20150507 sdp3430.txt 18: omap4-sdp-es23plus: PASS 4.1.0-rc2-next-20150507 sdp4430.txt TOTAL = 18 boards, Booted Boards = 18, No Boot boards = 0 TI boards do not have any orphan clocks. -Tero -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/