Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752165AbbEHLu4 (ORCPT ); Fri, 8 May 2015 07:50:56 -0400 Received: from www.linutronix.de ([62.245.132.108]:36706 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750968AbbEHLuw (ORCPT ); Fri, 8 May 2015 07:50:52 -0400 Message-ID: <554CA317.8050303@linutronix.de> Date: Fri, 08 May 2015 13:50:47 +0200 From: Sebastian Andrzej Siewior User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Fabio Estevam , Sebastian Andrzej Siewior CC: Greg Kroah-Hartman , jiwang , Jiri Slaby , "linux-serial@vger.kernel.org" , linux-kernel , anton_bondarenko@mentor.com, Dirk Behme , Nicolae Rosia , Fabio Estevam Subject: Re: [PATCH v2] serial: imx: Revert "initialized DMA w/o HW flow enabled" References: <20150507202439.GA4717@breakpoint.cc> <20150508071340.GA2603@breakpoint.cc> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1242 Lines: 34 On 05/08/2015 01:30 PM, Fabio Estevam wrote: > On Fri, May 8, 2015 at 4:13 AM, Sebastian Andrzej Siewior > wrote: > >> + >> + /* >> + * Can we enable the DMA support? Be aware that >> + * at least IMX6 needs to load external SDMA firmware in >> + * order work properly. The in-ROM firmware is not >> + * wokring properly. >> + */ > > On my tests: > > Prior to this patch: with the internal ROM SDMA firmware I got UART > issues when communicating through a Bluetooth module. With external > SDMA firmware (version 3.1) it worked fine. > > With your patch applied: Bluetooth worked fine even with no external > SDMA firmware, which does not match the comments you added. Why doesn't it match the comment? The patch disables DMA so the SDMA firmware does not matter. > Can't you just remove these comments? > > Thanks Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/