Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753152AbbEHMJd (ORCPT ); Fri, 8 May 2015 08:09:33 -0400 Received: from mail-vn0-f43.google.com ([209.85.216.43]:38205 "EHLO mail-vn0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751303AbbEHMJ3 (ORCPT ); Fri, 8 May 2015 08:09:29 -0400 MIME-Version: 1.0 In-Reply-To: <1431086300-5289-1-git-send-email-anda-maria.nicolae@intel.com> References: <1431086300-5289-1-git-send-email-anda-maria.nicolae@intel.com> Date: Fri, 8 May 2015 21:09:27 +0900 Message-ID: Subject: Re: [PATCH v4] power_supply: Add support for Richtek rt9455 battery charger From: =?UTF-8?Q?Krzysztof_Koz=C5=82owski?= To: Anda-Maria Nicolae Cc: sre@kernel.org, dbaryshkov@gmail.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, dwmw2@infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1195 Lines: 29 2015-05-08 20:58 GMT+09:00 Anda-Maria Nicolae : > diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig > index 4091fb0..b2b230c 100644 > --- a/drivers/power/Kconfig > +++ b/drivers/power/Kconfig > @@ -439,6 +439,13 @@ config BATTERY_RT5033 > The fuelgauge calculates and determines the battery state of charge > according to battery open circuit voltage. > > +config CHARGER_RT9455 > + tristate "Richtek RT9455 battery charger driver" > + depends on I2C && GPIOLIB > + depends on REGMAP_I2C Like I said previously, I still think you need to select it, not depend on it. This is not a user-selectable option, so depending on it may hide your driver. If you are unsure in such case you can always: $ git grep REGMAP_I2C Rest looks fine to me, so with the change above (s/depends on/select/): Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/