Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753386AbbEHO3h (ORCPT ); Fri, 8 May 2015 10:29:37 -0400 Received: from kiutl.biot.com ([31.172.244.210]:59584 "EHLO kiutl.biot.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752971AbbEHO3c (ORCPT ); Fri, 8 May 2015 10:29:32 -0400 Message-ID: <554CC847.6020004@biot.com> Date: Fri, 08 May 2015 16:29:27 +0200 From: Bert Vermeulen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Frans Klaver CC: David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] nand: Add NAND driver for Mikrotik RB4xx series boards References: <1431001910-4004-1-git-send-email-bert@biot.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 896 Lines: 25 On 05/08/2015 12:14 PM, Frans Klaver wrote: > On Thu, May 7, 2015 at 2:31 PM, Bert Vermeulen wrote: >> + >> + info->chip.priv = info; >> + info->mtd.priv = &info->chip; >> + info->mtd.owner = THIS_MODULE; > > If you should respin, could you add > > info->mtd.dev.parent = &pdev->dev; > > This will have a symlink to the parent device show up in sysfs. Seems > some people feel rather strongly about that. Sure, will do. I'll wait for some comment from David Woodhouse or Brian Norris first, in case there's something more substantial to fix as well. -- Bert Vermeulen bert@biot.com email/xmpp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/