Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752861AbbEHPDt (ORCPT ); Fri, 8 May 2015 11:03:49 -0400 Received: from smtprelay0076.hostedemail.com ([216.40.44.76]:60271 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751117AbbEHPDs (ORCPT ); Fri, 8 May 2015 11:03:48 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::,RULES_HIT:41:69:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3167:3352:3622:3874:3876:4321:4605:5007:6119:6261:7514:7875:7903:10004:10400:10848:10967:11232:11658:11914:12517:12519:12555:12740:13069:13311:13357:13846:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: mice14_3e0e76454a724 X-Filterd-Recvd-Size: 2269 Date: Fri, 8 May 2015 11:03:45 -0400 From: Steven Rostedt To: Denys Vlasenko Cc: Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Andy Lutomirski , Frederic Weisbecker , Alexei Starovoitov , Will Drewry , Kees Cook , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: force inlining of atomic ops Message-ID: <20150508110345.4f89cdf7@gandalf.local.home> In-Reply-To: <1431080762-17797-1-git-send-email-dvlasenk@redhat.com> References: <1431080762-17797-1-git-send-email-dvlasenk@redhat.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1372 Lines: 41 On Fri, 8 May 2015 12:26:02 +0200 Denys Vlasenko wrote: > This patch fixes this for x86 atomic ops via s/inline/__always_inline/. > This decreases allyesconfig kernel by about 25k: > > text data bss dec hex filename > 82399481 22255416 20627456 125282353 777a831 vmlinux.before > 82375570 22255544 20627456 125258570 7774b4a vmlinux I agree, there's no reason that atomic_* functions should not be inlined. Acked-by: Steven Rostedt -- Steve > > Signed-off-by: Denys Vlasenko > CC: Steven Rostedt > CC: Ingo Molnar > CC: Borislav Petkov > CC: "H. Peter Anvin" > CC: Andy Lutomirski > CC: Frederic Weisbecker > CC: Alexei Starovoitov > CC: Will Drewry > CC: Kees Cook > CC: x86@kernel.org > CC: linux-kernel@vger.kernel.org > --- > arch/x86/include/asm/atomic.h | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/