Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753625AbbEHPRP (ORCPT ); Fri, 8 May 2015 11:17:15 -0400 Received: from iodev.co.uk ([82.211.30.53]:56051 "EHLO iodev.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753534AbbEHPRJ (ORCPT ); Fri, 8 May 2015 11:17:09 -0400 Date: Fri, 8 May 2015 12:16:43 -0300 From: Ismael Luceno To: Jani Nikula , Chris Wilson Cc: Matt Roper , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix screen flickering on X Message-ID: <20150508121643.1f9d7f4b@pirotess> In-Reply-To: <20150508121015.2045085e@pirotess> References: <1428792034-6131-1-git-send-email-ismael@iodev.co.uk> <20150423091532.GA21511@nuc-i3427.alporthouse.com> <87zj5g69al.fsf@intel.com> <20150507132715.GA22531@intel.com> <87r3qs5wtf.fsf@intel.com> <20150508121015.2045085e@pirotess> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2138 Lines: 54 On Fri, 8 May 2015 12:10:15 -0300 Ismael Luceno wrote: > On Thu, 07 May 2015 16:41:48 +0300 > Jani Nikula wrote: > > On Thu, 07 May 2015, Matt Roper wrote: > > > On Thu, May 07, 2015 at 12:12:18PM +0300, Jani Nikula wrote: > > >> On Thu, 23 Apr 2015, Chris Wilson > > >> wrote: > > >> > [cc'ing the authors] > > >> > > >> This has been posted earlier [1] and it has review to be > > >> addressed [2]. > > >> > > >> BR, > > >> Jani. > > > > > > I agree with Ander's response in [2]...we can't call > > > intel_update_watermarks() in the commit function because we're > > > under vblank evasion. We should already be flagging the > > > transaction as needing a watermark update in > > > intel_check_cursor_plane(), and that flag will be acted upon > > > immediately after the commit functions are done running, once > > > we've re-enabled interrupts. > > > > > > Note that our current codebase looks a bit different since we've > > > dropped intel_crtc->cursor_{width,height}. So the relevant check > > > in intel_check_cursor_plane() now looks like: > > > > > > if (plane->state->crtc_w != state->base.crtc_w) > > > intel_crtc->atomic.update_wm = true; > > > > > > Is there a bugzilla open on this issue with more details? > > > > Not that I know of. Ismael? > > Didn't found one at the time. > > I apologize for the lack of communication, have been too busy job > hunting these weeks. > > Chris comments prompted me to double-check. It seems one of Matt's > commits solves the issue [0], it just didn't hit mainline until April > 20 [1], long after v4.0. > > [0] 3dd512fbda0d87d1c3fb44bf878b262baee98fb6 > [1] 14aa02449064541217836b9f3d3295e241d5ae9c Sorry, meant Matt's comment about the current codebase; my brain seems not to be working well today. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/