Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932243AbbEHQZN (ORCPT ); Fri, 8 May 2015 12:25:13 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:37211 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932117AbbEHQZH (ORCPT ); Fri, 8 May 2015 12:25:07 -0400 Date: Fri, 8 May 2015 18:24:52 +0200 From: Peter Zijlstra To: Robert Bragg Cc: intel-gfx@lists.freedesktop.org, Daniel Vetter , Jani Nikula , David Airlie , Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-api@vger.kernel.org Subject: Re: [RFC PATCH 00/11] drm/i915: Expose OA metrics via perf PMU Message-ID: <20150508162452.GR27504@twins.programming.kicks-ass.net> References: <1431008154-6833-1-git-send-email-robert@sixbynine.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431008154-6833-1-git-send-email-robert@sixbynine.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 815 Lines: 16 On Thu, May 07, 2015 at 03:15:43PM +0100, Robert Bragg wrote: > I've changed the uapi for configuring the i915_oa specific attributes > when calling perf_event_open(2) whereby instead of cramming lots of > bitfields into the perf_event_attr config members, I'm now > daisy-chaining a drm_i915_oa_event_attr_t structure off of a single > config member that's extensible and validated in the same way as the > perf_event_attr struct. I've found this much nicer to work with while > being neatly extensible too. This worries me a bit.. is there more background for this? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/