Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753578AbbEHRGN (ORCPT ); Fri, 8 May 2015 13:06:13 -0400 Received: from p3plex2out02.prod.phx3.secureserver.net ([184.168.131.14]:60159 "EHLO p3plex2out02.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752078AbbEHRGM convert rfc822-to-8bit (ORCPT ); Fri, 8 May 2015 13:06:12 -0400 From: Hartley Sweeten To: Ian Abbott , "driverdev-devel@linuxdriverproject.org" CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 0/6] staging: comedi: gsc_hpdi: some clean-ups Thread-Topic: [PATCH 0/6] staging: comedi: gsc_hpdi: some clean-ups Thread-Index: AQHQh1uVS3tqhGUf70ybFJwg/hHE9J1yU08w Date: Fri, 8 May 2015 17:06:10 +0000 Message-ID: References: <1430848049-29741-1-git-send-email-abbotti@mev.co.uk> In-Reply-To: <1430848049-29741-1-git-send-email-abbotti@mev.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [184.183.19.121] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1061 Lines: 22 On Tuesday, May 05, 2015 10:47 AM, Ian Abbott wrote: > Simplify (eliminate) the board type matching code, since only a single > board type is supported. Reformat the comments. Fix the checkpatch > issues. Use a better module description string. > > 1) staging: comedi: gsc_hpdi: tidy up comments > 2) staging: comedi: gsc_hpdi: remove multiple board type support > 3) staging: comedi: gsc_hpdi: usleep_range is preferred over udelay > 4) staging: comedi: gsc_hpdi: prefer using the BIT() macro > 5) staging: comedi: gsc_hpdi: use PCI_DEVICE_SUB() > 6) staging: comedi: gsc_hpdi: use a better MODULE_DESCRIPTION() > > drivers/staging/comedi/drivers/gsc_hpdi.c | 184 +++++++++++++----------------- > 1 file changed, 80 insertions(+), 104 deletions(-) Reviewed-by: H Hartley Sweeten -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/