Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932440AbbEHRaJ (ORCPT ); Fri, 8 May 2015 13:30:09 -0400 Received: from mail-ig0-f177.google.com ([209.85.213.177]:36730 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932072AbbEHRaF (ORCPT ); Fri, 8 May 2015 13:30:05 -0400 Date: Fri, 8 May 2015 10:30:03 -0700 From: Alexei Starovoitov To: Alexander Duyck Cc: Denys Vlasenko , "David S. Miller" , Jiri Pirko , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: [PATCH] net: deinline netif_tx_stop_queue() and netif_tx_stop_all_queues() Message-ID: <20150508172959.GA944@Alexeis-MBP.westell.com> References: <1430998870-1453-1-git-send-email-dvlasenk@redhat.com> <554B9D82.80101@gmail.com> <554C85B2.1010605@redhat.com> <554CDB4D.5050108@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <554CDB4D.5050108@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1248 Lines: 25 On Fri, May 08, 2015 at 08:50:37AM -0700, Alexander Duyck wrote: > > >>> f0 80 8f e0 01 00 00 01 lock orb $0x1,0x1e0(%rdi) > >>This is your set bit operation. If you were to drop the whole WARN_ON > >>then this is the only thing you would be inlining. > >It's up to networking people to decide. I would happily send a patch which drops > >WARN_ON if they say that's ok with them. Davem? > > This was added under commit 18543a643fae6 ("net: Detect and ignore > netif_stop_queue() calls before register_netdev()"). I think the time for > allowing drivers to ignore the WARN_ON has passed and at this point they > should be strongly encouraged to fix the issue via a NULL pointer > dereference if they still haven't gotten the issue resolved so we can track > them down and fix them. I'd say add a comment here in case someone triggers > this and does some debugging, but the WARN_ON at this point has proven it is > too expensive. +1 5 years for this WARN_ON was enough. Time to remove it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/