Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932403AbbEHRoF (ORCPT ); Fri, 8 May 2015 13:44:05 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:35654 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932237AbbEHRoB convert rfc822-to-8bit (ORCPT ); Fri, 8 May 2015 13:44:01 -0400 MIME-Version: 1.0 In-Reply-To: <1430986090-7243-2-git-send-email-geert@linux-m68k.org> References: <1430986090-7243-1-git-send-email-geert@linux-m68k.org> <1430986090-7243-2-git-send-email-geert@linux-m68k.org> From: Bryan Wu Date: Fri, 8 May 2015 10:43:39 -0700 Message-ID: Subject: Re: [PATCH 1/3] gpiolib: Add missing dummies for the unified device properties interface To: Geert Uytterhoeven Cc: Linus Walleij , Alexandre Courbot , Richard Purdie , Arnd Bergmann , Jacek Anaszewski , "linux-gpio@vger.kernel.org" , Linux LED Subsystem , lkml Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1901 Lines: 60 On Thu, May 7, 2015 at 1:08 AM, Geert Uytterhoeven wrote: > If GPIOLIB=n: > > drivers/leds/leds-gpio.c: In function ‘gpio_leds_create’: > drivers/leds/leds-gpio.c:187: error: implicit declaration of function ‘devm_get_gpiod_from_child’ > drivers/leds/leds-gpio.c:187: warning: assignment makes pointer from integer without a cast > > Add dummies for fwnode_get_named_gpiod() and devm_get_gpiod_from_child() > for the !GPIOLIB case to fix this. > Geert, This patch looks good to me. Do you mind merging it through LED tree with other 2 more LED patches? Thanks, -Bryan > Signed-off-by: Geert Uytterhoeven > Fixes: 40b7318319281b1b ("gpio: Support for unified device properties interface") > --- > include/linux/gpio/consumer.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h > index 3a7c9ffd5ab930b4..da042657dc31d7f5 100644 > --- a/include/linux/gpio/consumer.h > +++ b/include/linux/gpio/consumer.h > @@ -406,6 +406,21 @@ static inline int desc_to_gpio(const struct gpio_desc *desc) > return -EINVAL; > } > > +/* Child properties interface */ > +struct fwnode_handle; > + > +static inline struct gpio_desc *fwnode_get_named_gpiod( > + struct fwnode_handle *fwnode, const char *propname) > +{ > + return ERR_PTR(-ENOSYS); > +} > + > +static inline struct gpio_desc *devm_get_gpiod_from_child( > + struct device *dev, const char *con_id, struct fwnode_handle *child) > +{ > + return ERR_PTR(-ENOSYS); > +} > + > #endif /* CONFIG_GPIOLIB */ > > /* > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/