Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753490AbbEIANY (ORCPT ); Fri, 8 May 2015 20:13:24 -0400 Received: from ozlabs.org ([103.22.144.67]:49388 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbbEIAMg (ORCPT ); Fri, 8 May 2015 20:12:36 -0400 From: Rusty Russell To: Steven Rostedt Cc: LKML , Andrew Morton , stable , Pontus Fuchs Subject: Re: [PATCH] module: Call module notifier on failure after complete_formation() In-Reply-To: <20150508112248.2ce5af16@gandalf.local.home> References: <20150508111736.64d5176a@gandalf.local.home> <20150508112248.2ce5af16@gandalf.local.home> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Sat, 09 May 2015 03:26:18 +0930 Message-ID: <874mnnlzr1.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1088 Lines: 27 Steven Rostedt writes: > On Fri, 8 May 2015 11:17:36 -0400 > Steven Rostedt wrote: > >> >> The module notifier call chain for MODULE_STATE_COMING was moved up before >> the parsing of args, into the complete_formation() call. But if the module failed >> to load after that, the notifier call chain for MODULE_STATE_GOING was >> never called and that prevented the users of those call chains from >> cleaning up anything that was allocated. >> >> Link: http://lkml.kernel.org/r/554C52B9.9060700@gmail.com > > You can nuke the "Link". I didn't realize Pontus didn't Cc any mailing > lists, and I manually just added it. Usually my scripts will check if > lkml was Cc'd and only add the "Link" tag if it was. Just shows you > that my scripts are smarter than I am. Thanks for this. Applied, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/