Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932538AbbEHR7H (ORCPT ); Fri, 8 May 2015 13:59:07 -0400 Received: from mail-am1on0074.outbound.protection.outlook.com ([157.56.112.74]:28896 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932311AbbEHR7B (ORCPT ); Fri, 8 May 2015 13:59:01 -0400 Authentication-Results: spf=fail (sender IP is 12.216.194.146) smtp.mailfrom=ezchip.com; ezchip.com; dkim=none (message not signed) header.d=none; From: Chris Metcalf To: Gilad Ben Yossef , Steven Rostedt , Ingo Molnar , Peter Zijlstra , Andrew Morton , "Rik van Riel" , Tejun Heo , Frederic Weisbecker , Thomas Gleixner , "Paul E. McKenney" , Christoph Lameter , "Srivatsa S. Bhat" , CC: Chris Metcalf Subject: [PATCH 2/6] nohz: dataplane: allow tick to be fully disabled for dataplane Date: Fri, 8 May 2015 13:58:43 -0400 Message-ID: <1431107927-13998-3-git-send-email-cmetcalf@ezchip.com> X-Mailer: git-send-email 2.1.2 In-Reply-To: <1431107927-13998-1-git-send-email-cmetcalf@ezchip.com> References: <1431107927-13998-1-git-send-email-cmetcalf@ezchip.com> X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:12.216.194.146;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(339900001)(189002)(199003)(189998001)(19580405001)(42186005)(19580395003)(46102003)(77156002)(15975445007)(62966003)(47776003)(229853001)(33646002)(85426001)(104016003)(87936001)(106466001)(105606002)(36756003)(5001770100001)(5001960100002)(107886002)(6806004)(48376002)(92566002)(2950100001)(50466002)(50226001)(86362001)(76176999)(50986999)(921003)(4001430100001)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR02MB0421;H:ld-1.internal.tilera.com;FPR:;SPF:Fail;MLV:sfv;MX:1;A:1;LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM3PR02MB0421; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:AM3PR02MB0421;BCL:0;PCL:0;RULEID:;SRVR:AM3PR02MB0421; X-Forefront-PRVS: 0570F1F193 X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2015 17:58:56.9109 (UTC) X-MS-Exchange-CrossTenant-Id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0fc16e0a-3cd3-4092-8b2f-0a42cff122c3;Ip=[12.216.194.146];Helo=[ld-1.internal.tilera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR02MB0421 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2041 Lines: 50 While the current fallback to 1-second tick is still helpful for maintaining completely correct kernel semantics, processes using prctl(PR_SET_DATAPLANE) semantics place a higher priority on running completely tickless, so don't bound the time_delta for such processes. This was previously discussed in https://lkml.org/lkml/2014/10/31/364 and Thomas Gleixner observed that vruntime, load balancing data, load accounting, and other things might be impacted. Frederic Weisbecker similarly observed that allowing the tick to be indefinitely deferred just meant that no one would ever fix the underlying bugs. However it's at least true that the mode proposed in this patch can only be enabled on an isolcpus core, which may limit how important it is to maintain scheduler data correctly, for example. It's also worth observing that the tile architecture has been using similar code for its Zero-Overhead Linux for many years (starting in 2005) and customers are very enthusiastic about the resulting bare-metal performance on cores that are available to run full Linux semantics on demand (crash, logging, shutdown, etc). So this semantics is very useful if we can convince ourselves that doing this is safe. Signed-off-by: Chris Metcalf --- kernel/time/tick-sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 31c674719647..25fdd6bdd1eb 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -644,7 +644,7 @@ static ktime_t tick_nohz_stop_sched_tick(struct tick_sched *ts, } #ifdef CONFIG_NO_HZ_FULL - if (!ts->inidle) { + if (!ts->inidle && !tick_nohz_is_dataplane()) { time_delta = min(time_delta, scheduler_tick_max_deferment()); } -- 2.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/