Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752972AbbEHSHD (ORCPT ); Fri, 8 May 2015 14:07:03 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:56693 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751733AbbEHSG7 (ORCPT ); Fri, 8 May 2015 14:06:59 -0400 Date: Fri, 8 May 2015 19:06:44 +0100 From: Mark Brown To: Belisko Marek Cc: Liam Girdwood , perex@perex.cz, tiwai@suse.de, "devicetree@vger.kernel.org" , LKML , alsa-devel@alsa-project.org, "Dr. H. Nikolaus Schaller" Message-ID: <20150508180644.GI2761@sirena.org.uk> References: <1430856941-3938-1-git-send-email-marek@goldelico.com> <20150506121311.GP22845@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qLni7iB6Dl8qUSwk" Content-Disposition: inline In-Reply-To: X-Cookie: 13. ... r-q1 User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: bt-sco: Add devicetree support for bt-sco codec X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1796 Lines: 45 --qLni7iB6Dl8qUSwk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 06, 2015 at 09:38:55PM +0200, Belisko Marek wrote: > > Is there any burning reason for adding the linux,bt-sco compatible? > No no real reason just want to keep that if somebody would like use it from DT > referenced by bt-sco entry (similar as platform data). I'm adding DT > support for it because I want to use > this for W2CBW003 chip and I can use simply "linux,bt-sco" property in > DT or I instead of that add new vendor > prefix + add new compatible entry which is IMO much harder that > reference it by generic name. OK, can you change the patch to just have the part specific name please? If we were to have a generic binding it should really be richer than this, for example I think I've seen BT devices that take in 16kHz streams rather than 8kHz and there are often requirements for oversized data frames as well. --qLni7iB6Dl8qUSwk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVTPszAAoJECTWi3JdVIfQYCsH/10m/7wdBtY60QPlrD0RFlXZ INGbmNuDmF0pW4Z0Ys7g3Zi4irpnMQn/kZOhaHocBK3d+nrT1DWEFez7g58etEiH AT532QXLqKSPoOok7yhrZ/xLgVHasdkPlpLOQp7EQZ4+ASuIJTGeYSI1fUcgBeHq gjDdKt3auj0C0vszlJYCd/+Jo3ehvEEhvKemQ4h/X9ADbS1FIplJRG4eJz6WhV94 NZikgN95PQ+/JW+EHAWr78CN6b+on1cYZ22ijqC6csjlQk2xy0t836jrvoU0Rj0M dWvBKJ+AFvxYw70aY6GM3qVgzR4RrjuBgk70GwglgT8j47OUeu7DXKYisbPGmEo= =JQb2 -----END PGP SIGNATURE----- --qLni7iB6Dl8qUSwk-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/