Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932504AbbEHTA0 (ORCPT ); Fri, 8 May 2015 15:00:26 -0400 Received: from mail-ig0-f178.google.com ([209.85.213.178]:33080 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932173AbbEHTAV convert rfc822-to-8bit (ORCPT ); Fri, 8 May 2015 15:00:21 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Sebastian Hesselbarth , "Sebastian Hesselbarth" From: Michael Turquette In-Reply-To: <1430773456-15203-1-git-send-email-sebastian.hesselbarth@gmail.com> Cc: "Stephen Boyd" , "Jean-Francois Moine" , "Michael Welling" , "Russell King" , "Jason Cooper" , "Andrew Lunn" , "Gregory Clement" , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1430773456-15203-1-git-send-email-sebastian.hesselbarth@gmail.com> Message-ID: <20150508190010.16410.26923@quantum> User-Agent: alot/0.3.5 Subject: Re: [PATCH v2 0/3] clk: si5351: Fixes for v4.1-rc1 Date: Fri, 08 May 2015 12:00:10 -0700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2948 Lines: 72 Quoting Sebastian Hesselbarth (2015-05-04 14:04:13) > Mike, Stephen, > > this is v2 of dealing with recently reported clk-si5351 issues. Compared > to v1 [1], I decided to first split-off the pure fixes and postpone the > improvements to a later patch set. Patches 1 and 3 should go though clk > fixes while patch 2 should be taken by mvebu maintainers. > > This fixes are intended for v4.1-rc1 and deal with issues where DT claimed > parent clocks are not properly detected starting with v4.0. Looking at the > code of clk-si5351, I just realized that the way the driver deals with > parent clocks is utter nonsense. Russell King also mentioned that passing > struct clk though platform_data shouldn't be done at all. > > Therefore, this 3 patches rework parent clock handling of clk-si5351 to > make use of (a) named parent clocks, (b) devm_clk_get() for both DT- and > platform_data passed parent clocks, and (c) properly clk_prepare_enable() > valid parent clocks. > > However, I do have a stripped down backport of the fix for stable v4.0 > that just fixes the real issue, i.e. DT based probing and missing > clk_prepare_enable(). If you agree with this fixes for v4.1-rc1 we should > consider the backport for v4.0 stable. I've pushed patches #1 and #3 to clk-fixes, now merged into clk-next. I'll give it a couple of cycles in linux-next and then submit it for 4.1-rc4. Regards, Mike > > Overall changes compared to v1: > - Postpone improvement patch ("clk: si5351: Reset PLL after rate change") > for later patch set. > - Reword parent clock check error message. (Suggested by Fabio Estevam) > > Sebastian > > [1] https://lkml.org/lkml/2015/4/30/688 > > Sebastian Hesselbarth (3): > clk: si5351: Mention clock-names in the binding documentation > ARM: dove: Add clock-names to CuBox Si5351 clk generator > clk: si5351: Do not pass struct clk in platform_data > > .../devicetree/bindings/clock/silabs,si5351.txt | 4 +- > arch/arm/boot/dts/dove-cubox.dts | 1 + > drivers/clk/clk-si5351.c | 63 +++++++++++++++------- > include/linux/platform_data/si5351.h | 4 -- > 4 files changed, 49 insertions(+), 23 deletions(-) > > --- > Cc: Mike Turquette > Cc: Stephen Boyd > Cc: Jean-Francois Moine > Cc: Michael Welling > Cc: Russell King > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Gregory Clement > Cc: linux-clk@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > -- > 2.1.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/