Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932551AbbEHUSs (ORCPT ); Fri, 8 May 2015 16:18:48 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:2403 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932251AbbEHUSq (ORCPT ); Fri, 8 May 2015 16:18:46 -0400 Message-ID: <554D1A19.8010407@fb.com> Date: Fri, 8 May 2015 14:18:33 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Shaohua Li , CC: , , Subject: Re: [PATCH 1/6 v2] blk: clean up plug References: <726972cd3a12680e1b2ac819f989c0f65c77c1b4.1431106907.git.shli@fb.com> In-Reply-To: <726972cd3a12680e1b2ac819f989c0f65c77c1b4.1431106907.git.shli@fb.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-05-08_07:2015-05-08,2015-05-08,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 679 Lines: 17 On 05/08/2015 11:51 AM, Shaohua Li wrote: > Current code looks like inner plug gets flushed with a > blk_finish_plug(). Actually it's a nop. All requests/callbacks are added > to current->plug, while only outmost plug is assigned to current->plug. > So inner plug always has empty request/callback list, which makes > blk_flush_plug_list() a nop. This tries to make the code more clear. Applied 1-6, thanks Shaohua! -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/