Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932379AbbEHUOT (ORCPT ); Fri, 8 May 2015 16:14:19 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:58784 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932072AbbEHUOQ (ORCPT ); Fri, 8 May 2015 16:14:16 -0400 From: "Rafael J. Wysocki" To: One Thousand Gnomes Cc: Len Brown , Alan Stern , Linux PM list , "linux-kernel@vger.kernel.org" , Len Brown Subject: Re: [PATCH 1/1] suspend: delete sys_sync() Date: Fri, 08 May 2015 22:39:21 +0200 Message-ID: <1766178.k5mi2k4gBr@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.0.0+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150508205233.72b9fae3@lxorguk.ukuu.org.uk> References: <20150508205233.72b9fae3@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1311 Lines: 29 On Friday, May 08, 2015 08:52:33 PM One Thousand Gnomes wrote: > > > Some of this however is crappy suspend/resume handling. If the suspend > > > subsystem was doing its job then for the cases of timeout triggered > > > suspend it would have triggered most of the disk writes ten seconds > > > before it tried to suspend properly ;-) > > > > No problem, continue to use s2ram on your system -- and to the extent > > that sync works, your data will be on disk. (sync reliability is a > > different topic...) > > Ok let me ask the other obvious question. For all the mainstream > distributions do their default tools and setup sync such that removing it > from the kernel won't actually be noticable by users ? > > If the answer is yes, then I shall shut up and stop worrying 8) The distros I'm familiar with do that. It has always been done traditionally and I don't think anyone had enough guts to remove it from the scripts. :-) We need to be more careful about Android as I said, but that can be addressed by adding sync() to the autosleep thread. Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/