Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753268AbbEHXuk (ORCPT ); Fri, 8 May 2015 19:50:40 -0400 Received: from mail-ie0-f180.google.com ([209.85.223.180]:34418 "EHLO mail-ie0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752841AbbEHXuf (ORCPT ); Fri, 8 May 2015 19:50:35 -0400 Date: Fri, 8 May 2015 16:50:31 -0700 From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: =?iso-8859-1?Q?S=E9bastien?= Szymanski , linux-kernel@vger.kernel.org Subject: [PATCH] Input: sx8654 - fix memory allocation check Message-ID: <20150508235031.GA29274@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1004 Lines: 34 We have been testing wrong variable when trying to make sure that input allocation succeeded. Reported by Coverity (CID 1295918). Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/sx8654.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/sx8654.c b/drivers/input/touchscreen/sx8654.c index aecb9ad..642f4a5 100644 --- a/drivers/input/touchscreen/sx8654.c +++ b/drivers/input/touchscreen/sx8654.c @@ -187,7 +187,7 @@ static int sx8654_probe(struct i2c_client *client, return -ENOMEM; input = devm_input_allocate_device(&client->dev); - if (!sx8654) + if (!input) return -ENOMEM; input->name = "SX8654 I2C Touchscreen"; -- 2.2.0.rc0.207.ga3a616c -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/