Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753258AbbEIAms (ORCPT ); Fri, 8 May 2015 20:42:48 -0400 Received: from mail-vn0-f45.google.com ([209.85.216.45]:34388 "EHLO mail-vn0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753159AbbEIAmq (ORCPT ); Fri, 8 May 2015 20:42:46 -0400 MIME-Version: 1.0 In-Reply-To: <554CFFEB.1010703@kernel.org> References: <1430873718-22726-1-git-send-email-k.kozlowski@samsung.com> <554CFFEB.1010703@kernel.org> Date: Sat, 9 May 2015 09:42:45 +0900 X-Google-Sender-Auth: mZN-C9k95XLO0wNQcg1MvAG_m4A Message-ID: Subject: Re: ARM: EXYNOS: Fixes for 4.1 From: Krzysztof Kozlowski To: Kukjin Kim Cc: Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Olof Johansson , Arnd Bergmann Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1720 Lines: 46 2015-05-09 3:26 GMT+09:00 Kukjin Kim : > On 05/06/15 09:55, Krzysztof Kozlowski wrote: >> Krzysztof Kozlowski (1): >> ARM: EXYNOS: Fix failed second suspend on Exynos4 >> >> arch/arm/mach-exynos/common.h | 2 ++ >> arch/arm/mach-exynos/exynos.c | 27 +++++++++++++++++++++++++++ >> arch/arm/mach-exynos/platsmp.c | 39 ++------------------------------------- >> arch/arm/mach-exynos/suspend.c | 3 +++ >> 4 files changed, 34 insertions(+), 37 deletions(-) >> -- > > Hi Krzysztof, > > Yeah, the patch is old thing but if I remember correctly, I couldn't > apply it because of soc_is_xxx() macro. Yes, I agree with the way, > firstly fix something and if required, then update it later....But! > > Please address comments about that, if not, it will not be accepted by > arm-soc tree. Hi, Actually during previous discussion I addressed all the issues: https://lkml.org/lkml/2015/3/18/108 but there was no response from your side. In previous thread you also asked about proper way of using the DELAYED_RESET_ASSERTION. I tried to obtain additional docs from LSI but couldn't. In current documentation it was described vaguely so I looked at vendor source code. The patch IMHO is the best solution. Additionally it was tested (Chanwoo and Bartlomiej) and fixes the issue. As for the soc_is_exynos -> of_machine_is_compatible I will prepare a follow up to fix this. Let me know if you have any other comments about it. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/