Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753501AbbEIJR7 (ORCPT ); Sat, 9 May 2015 05:17:59 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:35595 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753196AbbEIJR4 (ORCPT ); Sat, 9 May 2015 05:17:56 -0400 Message-ID: <554DD0BF.9080108@gmail.com> Date: Sat, 09 May 2015 11:17:51 +0200 From: Jens Kuske User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Paul Bolle , Maxime Ripard CC: =?UTF-8?B?RW1pbGlvIEzDs3Bleg==?= , Mike Turquette , Linus Walleij , Vinod Koul , Rob Herring , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 3/6] pinctrl: sunxi: Add H3 PIO controller support References: <1430904693-1404-1-git-send-email-jenskuske@gmail.com> <1430904693-1404-4-git-send-email-jenskuske@gmail.com> <1430986247.8171.37.camel@x220> In-Reply-To: <1430986247.8171.37.camel@x220> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1784 Lines: 55 Hi, On 07/05/15 10:10, Paul Bolle wrote: > On Wed, 2015-05-06 at 11:31 +0200, Jens Kuske wrote: >> --- a/drivers/pinctrl/sunxi/Kconfig >> +++ b/drivers/pinctrl/sunxi/Kconfig > >> +config PINCTRL_SUN8I_H3 >> + def_bool MACH_SUN8I >> + select PINCTRL_SUNXI_COMMON > >> --- a/drivers/pinctrl/sunxi/Makefile >> +++ b/drivers/pinctrl/sunxi/Makefile > >> +obj-$(CONFIG_PINCTRL_SUN8I_H3) += pinctrl-sun8i-h3.o > > PINCTRL_SUN8I_H3 is a bool symbol, so pinctrl-sun8i-h3.o will never be > part of a module, right? > > (Note that PINCTRL_SUN8I_H3 appears to be an alias for MACH_SUN8I. Ie, > these two symbols operate in lockstep.) > >> --- /dev/null >> +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c > >> +#include > >> +MODULE_DEVICE_TABLE(of, sun8i_h3_pinctrl_match); > >> +MODULE_AUTHOR("Jens Kuske "); >> +MODULE_DESCRIPTION("Allwinner H3 pinctrl driver"); >> +MODULE_LICENSE("GPL"); > > This adds some module specific boilerplate. Was it perhaps your > intention to make PINCTRL_SUN8I_H3 a tristate symbol? > I don't know to be honest, I just followed the pattern of all the other pinctrl-sun?i-*.c files. But it sounds logical that this is needless in the current state. Looks like it got introduced when splitting up the driver: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-April/251712.html Maybe there were plans to use separate modules some day. If not, we should remove it from the other files as well I guess. Maxime, could you please comment on that? Regards, Jens -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/