Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751178AbbEILaL (ORCPT ); Sat, 9 May 2015 07:30:11 -0400 Received: from down.free-electrons.com ([37.187.137.238]:45831 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750851AbbEILaE (ORCPT ); Sat, 9 May 2015 07:30:04 -0400 Date: Sat, 9 May 2015 13:29:36 +0200 From: Maxime Ripard To: Jens Kuske Cc: Chen-Yu Tsai , Emilio =?iso-8859-1?Q?L=F3pez?= , Mike Turquette , Linus Walleij , Vinod Koul , Rob Herring , devicetree , linux-arm-kernel , linux-kernel , linux-sunxi Subject: Re: [PATCH 2/6] clk: sunxi: Add H3 clocks support Message-ID: <20150509112936.GU11057@lukather> References: <1430904693-1404-1-git-send-email-jenskuske@gmail.com> <1430904693-1404-3-git-send-email-jenskuske@gmail.com> <5549EA63.5060602@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="iBHcHRCIarfY7C0j" Content-Disposition: inline In-Reply-To: <5549EA63.5060602@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2532 Lines: 69 --iBHcHRCIarfY7C0j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 06, 2015 at 12:18:11PM +0200, Jens Kuske wrote: > >> /** > >> * sunxi_divs_clk_setup() - Setup function for leaf divisors on clocks > >> * > >> @@ -1252,6 +1288,7 @@ static const struct of_device_id clk_factors_mat= ch[] __initconst =3D { > >> {.compatible =3D "allwinner,sun5i-a13-ahb-clk", .data =3D &sun= 5i_a13_ahb_data,}, > >> {.compatible =3D "allwinner,sun4i-a10-apb1-clk", .data =3D &su= n4i_apb1_data,}, > >> {.compatible =3D "allwinner,sun7i-a20-out-clk", .data =3D &sun= 7i_a20_out_data,}, > >> + {.compatible =3D "allwinner,sun8i-h3-pll8-clk", .data =3D &sun= 8i_h3_pll8_data,}, > >=20 > > Matching comment above, no need to add a new compatible for something t= hat's > > the same. >=20 > PLL8 doesn't have a x2 output according to User Manual, but I did it > wrong anyway, see first comment. Don't worry too much about that output. It's not really an output, it's a pre-multiplier on a single child. We're discussing with Chen-Yu about refactoring this anyway, so it will probably go away in a near future. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --iBHcHRCIarfY7C0j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVTe+gAAoJEBx+YmzsjxAgKq4P/RcDy3DQKmRttlBZ87WallqH +MQcqq7hcECpzgq9NRjeiyL8nzl2e72bg20tM5mUB3xpBS/KHOwvB1WCf+muhhDj ucv9dsOxUgwdl1qnHO6O/tuda5KYBZXkEc7TLa1nu3oL8+2qDzPdVxtBSztg2YBC cYWwzgs8JSIuU6JmijwDkScuauWDZPHaCs86n7MLwlfLpNfhoxPNReSTxrFY/oJT Igbe9jx6YZZ53CPoadueWJUIgXlJHnQ025rEknppkuMhl6RlIXLdQ+ekHwgJR9/9 JGFXqSy2SJhAEhsoqaqMNEULKRJl8feXysE5kbPzCttP+ZpT6UA0Fvxagv8m3dkn VSWyoZH3wQj8bMrZ7ZIrMhvcv0eFpMZM6VcwSqrH1KazMci2wcLUCuB5CRJoxWY3 fm4QjafJfakoIxH8/83ovCLgAtQa7yujlEZA5KLfrwq6X9vu0CTg/Wlh9twJibuO EthmTvjiCFBcGccPI7QJdZeu9E4Dm5Z2LrIyDzZwIh6rFjo+fsulZ7ZdGmu5jnVv 5dcVl8nn5ZVKC0cl5mNAupASZhzkydXSDz3uarGATe6/VW0Vragi/f/5ZFnpyYo7 K13+QB+xs3o/Xr4Sn5Iq3eAl31j7X0AAeMlJk0rEnRzObOl96Oq3FDdQrlk9z2I2 jk6RGkotdMI7FkPriLV2 =zQ9q -----END PGP SIGNATURE----- --iBHcHRCIarfY7C0j-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/